Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2757453003: Purge impl-only animations awaiting deletion in AnimationPlayer::UpdateState. (Closed)

Created:
3 years, 9 months ago by skobes
Modified:
3 years, 9 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, loyso (OOO), ymalik, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Purge impl-only animations awaiting deletion in AnimationPlayer::UpdateState. Previously, animations in WAITING_FOR_DELETION state would only be purged via AnimationPlayer::PushPropertiesTo, which synchronizes impl- and main-thread players. But the player in ScrollOffsetAnimationsImpl has no main-thread copy, so its animations never got deleted after they finished. BUG=701025 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2757453003 Cr-Commit-Position: refs/heads/master@{#457443} Committed: https://chromium.googlesource.com/chromium/src/+/e26333eb717aa94b9f05ccf34ec91bfe31927f2a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M cc/animation/animation_player.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
skobes
3 years, 9 months ago (2017-03-16 03:32:35 UTC) #6
ajuma
lgtm
3 years, 9 months ago (2017-03-16 14:28:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757453003/1
3 years, 9 months ago (2017-03-16 15:30:21 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 15:37:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e26333eb717aa94b9f05ccf34ec9...

Powered by Google App Engine
This is Rietveld 408576698