Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2756883002: Use NiceMock for MediaSession/AudioFocus tests (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
whywhat
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use NiceMock for MediaSession/AudioFocus tests As per https://github.com/google/googlemock/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect, this is to avoid printing too many warnings for uninsterested calls to mocked methods. BUG=699112 Review-Url: https://codereview.chromium.org/2756883002 Cr-Commit-Position: refs/heads/master@{#458011} Committed: https://chromium.googlesource.com/chromium/src/+/ff2ee4a30a7b0170e27b227c11157b7844e79c99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M content/browser/media/session/media_session_impl_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/media/session/media_session_impl_service_routing_unittest.cc View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-17 13:47:18 UTC) #2
whywhat
lgtm
3 years, 9 months ago (2017-03-19 23:55:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756883002/1
3 years, 9 months ago (2017-03-19 23:56:03 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 01:19:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff2ee4a30a7b0170e27b227c1115...

Powered by Google App Engine
This is Rietveld 408576698