Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11252)

Unified Diff: content/browser/media/session/media_session_impl_browsertest.cc

Issue 2756883002: Use NiceMock for MediaSession/AudioFocus tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/session/media_session_impl_service_routing_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/session/media_session_impl_browsertest.cc
diff --git a/content/browser/media/session/media_session_impl_browsertest.cc b/content/browser/media/session/media_session_impl_browsertest.cc
index 7b461af1d982efae6b092939133788ca94835b77..1c061f17c7e658e19640b8716f432f305e5067d3 100644
--- a/content/browser/media/session/media_session_impl_browsertest.cc
+++ b/content/browser/media/session/media_session_impl_browsertest.cc
@@ -35,6 +35,7 @@ using content::MediaSessionUmaHelper;
using content::MockMediaSessionPlayerObserver;
using ::testing::Expectation;
+using ::testing::NiceMock;
using ::testing::_;
namespace {
@@ -71,8 +72,8 @@ class MediaSessionImplBrowserTest : public content::ContentBrowserTest {
media_session_ = MediaSessionImpl::Get(shell()->web_contents());
mock_media_session_observer_.reset(
- new content::MockMediaSessionObserver(media_session_));
- mock_audio_focus_delegate_ = new MockAudioFocusDelegate;
+ new NiceMock<content::MockMediaSessionObserver>(media_session_));
+ mock_audio_focus_delegate_ = new NiceMock<MockAudioFocusDelegate>;
media_session_->SetDelegateForTests(
base::WrapUnique(mock_audio_focus_delegate_));
ASSERT_TRUE(media_session_);
@@ -145,7 +146,7 @@ class MediaSessionImplBrowserTest : public content::ContentBrowserTest {
void SystemStopDucking() { media_session_->StopDucking(); }
void EnsureMediaSessionService() {
- mock_media_session_service_.reset(new MockMediaSessionServiceImpl(
+ mock_media_session_service_.reset(new NiceMock<MockMediaSessionServiceImpl>(
shell()->web_contents()->GetMainFrame()));
}
« no previous file with comments | « no previous file | content/browser/media/session/media_session_impl_service_routing_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698