Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2756773002: Ensure UKM only sends URLs under a specific length (currently 2K). (Closed)

Created:
3 years, 9 months ago by rkaplow
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure UKM only sends URLs under a specific length (currently 2K). BUG=678682 Review-Url: https://codereview.chromium.org/2756773002 Cr-Commit-Position: refs/heads/master@{#457802} Committed: https://chromium.googlesource.com/chromium/src/+/ab82339347fc9e1ef796652945996cd746469b03

Patch Set 1 #

Patch Set 2 : small fix #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M components/ukm/ukm_service_unittest.cc View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M components/ukm/ukm_source.cc View 1 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
rkaplow
3 years, 9 months ago (2017-03-16 22:05:55 UTC) #5
Bryan McQuade
lgtm
3 years, 9 months ago (2017-03-16 22:08:52 UTC) #6
Steven Holte
lgtm
3 years, 9 months ago (2017-03-16 23:03:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756773002/20001
3 years, 9 months ago (2017-03-17 02:45:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/387857)
3 years, 9 months ago (2017-03-17 02:52:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756773002/40001
3 years, 9 months ago (2017-03-17 15:49:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/138968) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 9 months ago (2017-03-17 16:18:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756773002/40001
3 years, 9 months ago (2017-03-17 16:28:25 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 17:25:25 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ab82339347fc9e1ef79665294599...

Powered by Google App Engine
This is Rietveld 408576698