Issue 2756653002: Remove ink drop effect after clicking the settings button on an ARC notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2756653002: Remove ink drop effect after clicking the settings button on an ARC notification. (Closed)

Created:
3 years, 9 months ago by yoshiki

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Remove ink drop effect after clicking the settings button on an ARC notification. BUG=b/36000828 BUG=700903 Review-Url: https://codereview.chromium.org/2734153002 Cr-Commit-Position: refs/heads/master@{#455318} (cherry picked from commit fea9ebc8a336166c3c130aa00fa64a72d55d9bec) Review-Url: https://codereview.chromium.org/2756653002 . Cr-Commit-Position: refs/branch-heads/3029@{#225} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/62cac5ce05789689c72fe9004b4a705397b1569e

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -23 lines)			Patch
	M	ui/arc/notification/arc_custom_notification_view.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
	M	ui/arc/notification/arc_custom_notification_view.cc	View		3 chunks	+25 lines, -20 lines	0 comments	Download

Total messages: 2 (1 generated)

yoshiki

3 years, 9 months ago (2017-03-16 05:11:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
62cac5ce05789689c72fe9004b4a705397b1569e.