Remove ink drop effect after clicking the settings button on an ARC notification.

Remove ink drop effect after clicking the settings button on an ARC notification.

BUG=b/36000828

Review-Url: https://codereview.chromium.org/2734153002
Cr-Commit-Position: refs/heads/master@{#455318}
Committed: https://chromium.googlesource.com/chromium/src/+/fea9ebc8a336166c3c130aa00fa64a72d55d9bec

[yhanada, 2017-03-07 13:11:05]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 13:11:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 13:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 13:42:18]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-03-07 14:26:10]

yhanada@chromium.org changed reviewers:
+ yoshiki@chromium.org

[yhanada, 2017-03-07 14:26:11]

PTAL.

[yoshiki, 2017-03-07 14:59:29]

lgtm with nit

https://codereview.chromium.org/2734153002/diff/1/ui/arc/notification/arc_cus...
File ui/arc/notification/arc_custom_notification_view.cc (right):

https://codereview.chromium.org/2734153002/diff/1/ui/arc/notification/arc_cus...
ui/arc/notification/arc_custom_notification_view.cc:180:
ArcCustomNotificationView* const owner_;
nit: Could you add DISALLOW_COPY_AND_ASSIGN(ControlButton);?

[yhanada, 2017-03-08 00:27:00]

Thank you for reviewing.

https://codereview.chromium.org/2734153002/diff/1/ui/arc/notification/arc_cus...
File ui/arc/notification/arc_custom_notification_view.cc (right):

https://codereview.chromium.org/2734153002/diff/1/ui/arc/notification/arc_cus...
ui/arc/notification/arc_custom_notification_view.cc:180:
ArcCustomNotificationView* const owner_;
On 2017/03/07 14:59:29, yoshiki wrote:
> nit: Could you add DISALLOW_COPY_AND_ASSIGN(ControlButton);?

Done.

[yhanada, 2017-03-08 00:27:06]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-03-08 00:27:07]

The patchset sent to the CQ was uploaded after l-g-t-m from yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/2734153002/#ps20001
(title: "address the comment")

[commit-bot: I haz the power, 2017-03-08 00:28:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:12:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488932826529960,
"parent_rev": "b381061316947dbceed438908696566dc32fc44e", "commit_rev":
"fea9ebc8a336166c3c130aa00fa64a72d55d9bec"}

[commit-bot: I haz the power, 2017-03-08 01:14:15]

Description was changed from

==========
Remove ink drop effect after clicking the settings button on an ARC
notification.

BUG=b/36000828
==========

to

==========
Remove ink drop effect after clicking the settings button on an ARC
notification.

BUG=b/36000828

Review-Url: https://codereview.chromium.org/2734153002
Cr-Commit-Position: refs/heads/master@{#455318}
Committed:
https://chromium.googlesource.com/chromium/src/+/fea9ebc8a336166c3c130aa00fa6...
==========

[commit-bot: I haz the power, 2017-03-08 01:14:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fea9ebc8a336166c3c130aa00fa6...