Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2734153002: Remove ink drop effect after clicking the settings button on an ARC notification. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ink drop effect after clicking the settings button on an ARC notification. BUG=b/36000828 Review-Url: https://codereview.chromium.org/2734153002 Cr-Commit-Position: refs/heads/master@{#455318} Committed: https://chromium.googlesource.com/chromium/src/+/fea9ebc8a336166c3c130aa00fa64a72d55d9bec

Patch Set 1 #

Total comments: 2

Patch Set 2 : address the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M ui/arc/notification/arc_custom_notification_view.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 1 3 chunks +25 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yhanada
PTAL.
3 years, 9 months ago (2017-03-07 14:26:11 UTC) #6
yoshiki
lgtm with nit https://codereview.chromium.org/2734153002/diff/1/ui/arc/notification/arc_custom_notification_view.cc File ui/arc/notification/arc_custom_notification_view.cc (right): https://codereview.chromium.org/2734153002/diff/1/ui/arc/notification/arc_custom_notification_view.cc#newcode180 ui/arc/notification/arc_custom_notification_view.cc:180: ArcCustomNotificationView* const owner_; nit: Could you ...
3 years, 9 months ago (2017-03-07 14:59:29 UTC) #7
yhanada
Thank you for reviewing. https://codereview.chromium.org/2734153002/diff/1/ui/arc/notification/arc_custom_notification_view.cc File ui/arc/notification/arc_custom_notification_view.cc (right): https://codereview.chromium.org/2734153002/diff/1/ui/arc/notification/arc_custom_notification_view.cc#newcode180 ui/arc/notification/arc_custom_notification_view.cc:180: ArcCustomNotificationView* const owner_; On 2017/03/07 ...
3 years, 9 months ago (2017-03-08 00:27:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734153002/20001
3 years, 9 months ago (2017-03-08 00:28:08 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:14:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fea9ebc8a336166c3c130aa00fa6...

Powered by Google App Engine
This is Rietveld 408576698