DevTools: extract bindings from ShellDevToolsFrontend

DevTools: extract bindings from ShellDevToolsFrontend

Our goal is to enable running a subset of new devtools tests so that
devtools is the main window under test and the inspected page is the
secondary window. However, our existing devtools tests currently have
the inspected page as the main window which then triggers opening devtools.

Since we'll need to run both our existing and new type of tests, we want
to create a way of flexibly binding the devtools and inspected windows.

After this CL lands:
* Implement the new type of devtools test where devtools is the main window
* Convert existing tests into the new type of tests
* Once everything has been converted, clean up test infra code for 
the old type of tests

BUG=667560
Review-Url: https://codereview.chromium.org/2756623002
Cr-Commit-Position: refs/heads/master@{#459337}
Committed: https://chromium.googlesource.com/chromium/src/+/fed5bda99ca38b4e2575614c87e858f51b2a8194

[chenwilliam, 2017-03-16 18:31:37]

Description was changed from

==========
DevTools: extract bindings from ShellDevToolsFrontend

This will help our test infrastructure.

BUG=667560
==========

to

==========
DevTools: extract bindings from ShellDevToolsFrontend

This is preparatory work for improving DevTools test infrastructure.

BUG=667560
==========

[chenwilliam, 2017-03-16 18:31:38]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2017-03-16 18:31:52]

ptal :)

[dgozman, 2017-03-16 21:38:07]

Let's have a plan of action and motivation in CL description.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:499: if
(secondary_window_.get() == devtools_window_)
This is always true.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:829:
devtools_bindings_->DisconnectFromTarget();
Can we instead destroy bindings when the test finishes? It's a cheap object
which doesn't really do anything, so should be ok.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.h:237: // Points to
either main_window_ or secondary_window_
Is that a case yet?

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_devtools_bindings.cc (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_bindings.cc:20: #include
"content/public/browser/render_widget_host.h"
Do you need this?

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_bindings.cc:346: WebContentsDelegate*
delegate = devtools_contents_->GetDelegate();
This belongs to ShellDevToolsFrontend. You can notify it through a thin
delegate.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_devtools_frontend.cc (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:41:
devtools_bindings_->Activate();
Let's not delegate this to bindings.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:45:
devtools_bindings_->Focus();
ditto

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:56: void
ShellDevToolsFrontend::DisconnectFromTarget() {
Is this used by anyone now?

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:66:
frontend_shell->web_contents()->SetDelegate(frontend_shell);
Why this call?

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_devtools_frontend.h (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.h:12: #include
"content/shell/browser/shell_devtools_bindings.h"
Forward-declare it instead.

[chenwilliam, 2017-03-16 22:00:06]

Description was changed from

==========
DevTools: extract bindings from ShellDevToolsFrontend

This is preparatory work for improving DevTools test infrastructure.

BUG=667560
==========

to

==========
DevTools: extract bindings from ShellDevToolsFrontend

Our goal is to enable running a subset of new devtools tests so that
devtools is the main window under test and the inspected page is the
secondary window. However, our existing devtools tests currently have
the inspected page as the main window which then triggers opening devtools.

Since we'll need to run both our existing and new type of tests, we want
to create a way of flexibly binding the devtools and inspected windows.

After this CL lands:
* Restructure BlinkTestController so it creates new bindings in each 
devtools test (it should be a small overhead since we're re-using the shells)
* Implement the new type of devtools test where devtools is the main window

BUG=667560
==========

[chenwilliam, 2017-03-17 19:14:36]

Description was changed from

==========
DevTools: extract bindings from ShellDevToolsFrontend

Our goal is to enable running a subset of new devtools tests so that
devtools is the main window under test and the inspected page is the
secondary window. However, our existing devtools tests currently have
the inspected page as the main window which then triggers opening devtools.

Since we'll need to run both our existing and new type of tests, we want
to create a way of flexibly binding the devtools and inspected windows.

After this CL lands:
* Restructure BlinkTestController so it creates new bindings in each 
devtools test (it should be a small overhead since we're re-using the shells)
* Implement the new type of devtools test where devtools is the main window

BUG=667560
==========

to

==========
DevTools: extract bindings from ShellDevToolsFrontend

Our goal is to enable running a subset of new devtools tests so that
devtools is the main window under test and the inspected page is the
secondary window. However, our existing devtools tests currently have
the inspected page as the main window which then triggers opening devtools.

Since we'll need to run both our existing and new type of tests, we want
to create a way of flexibly binding the devtools and inspected windows.

After this CL lands:
* Implement the new type of devtools test where devtools is the main window
* Convert existing tests into the new type of tests
* Once everything has been converted, clean up test infra code for 
the old type of tests

BUG=667560
==========

[chenwilliam, 2017-03-17 22:08:27]

ptal.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:499: if
(secondary_window_.get() == devtools_window_)
On 2017/03/16 21:38:07, dgozman wrote:
> This is always true.

Removed (will do in f/u patch). I took out the devtools_window_->Close() because
it would've caused two deletes in the headless chrome case.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:829:
devtools_bindings_->DisconnectFromTarget();
On 2017/03/16 21:38:07, dgozman wrote:
> Can we instead destroy bindings when the test finishes? It's a cheap object
> which doesn't really do anything, so should be ok.

Done.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.h:237: // Points to
either main_window_ or secondary_window_
On 2017/03/16 21:38:07, dgozman wrote:
> Is that a case yet?

Not yet. Removed.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_devtools_bindings.cc (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_bindings.cc:20: #include
"content/public/browser/render_widget_host.h"
On 2017/03/16 21:38:07, dgozman wrote:
> Do you need this?

Removed.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_bindings.cc:346: WebContentsDelegate*
delegate = devtools_contents_->GetDelegate();
On 2017/03/16 21:38:07, dgozman wrote:
> This belongs to ShellDevToolsFrontend. You can notify it through a thin
> delegate.

Done.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_devtools_frontend.cc (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:41:
devtools_bindings_->Activate();
On 2017/03/16 21:38:07, dgozman wrote:
> Let's not delegate this to bindings.

Done.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:45:
devtools_bindings_->Focus();
On 2017/03/16 21:38:07, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:56: void
ShellDevToolsFrontend::DisconnectFromTarget() {
On 2017/03/16 21:38:07, dgozman wrote:
> Is this used by anyone now?

Nope, removed.

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.cc:66:
frontend_shell->web_contents()->SetDelegate(frontend_shell);
On 2017/03/16 21:38:07, dgozman wrote:
> Why this call?

No longer needed since I'm using ShellDevToolsDelegate

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_devtools_frontend.h (right):

https://codereview.chromium.org/2756623002/diff/20001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.h:12: #include
"content/shell/browser/shell_devtools_bindings.h"
On 2017/03/16 21:38:07, dgozman wrote:
> Forward-declare it instead.

I added ShellDevToolsDelegate (for closing) so I need to include it now.

[dgozman, 2017-03-17 22:44:14]

Looks pretty good!

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:499: devtools_window_
= nullptr;
Reset devtools_bindings_.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:669:
devtools_bindings_.reset();
Let's instead do this in DiscardMainWindow.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:819: browser_context,
GURL(), NULL, initial_size_));
nullptr

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:829:
devtools_bindings_->CreateFrontendHost();
Let's combine this and two previous calls into
devtools_bindings_->LoadDevTools(frontend_url, settings).

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.h:235:
std::unique_ptr<Shell> secondary_window_;
Let's call this devtools_window_ and remove one below.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
File content/shell/browser/shell_devtools_bindings.h (right):

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
content/shell/browser/shell_devtools_bindings.h:28: virtual void Close() = 0;
You also need empty virtual destructor.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
content/shell/browser/shell_devtools_bindings.h:53: void SetPreferences(const
std::string& json);
This should be protected.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
File content/shell/browser/shell_devtools_frontend.h (right):

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.h:19: class ShellDevToolsFrontend
: ShellDevToolsDelegate {
: public ShellDevToolsDelegate

[chenwilliam, 2017-03-20 21:32:21]

please take another look, thank you.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:499: devtools_window_
= nullptr;
On 2017/03/17 22:44:14, dgozman wrote:
> Reset devtools_bindings_.

Done.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:669:
devtools_bindings_.reset();
On 2017/03/17 22:44:14, dgozman wrote:
> Let's instead do this in DiscardMainWindow.

Done.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:819: browser_context,
GURL(), NULL, initial_size_));
On 2017/03/17 22:44:14, dgozman wrote:
> nullptr

Done.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.cc:829:
devtools_bindings_->CreateFrontendHost();
On 2017/03/17 22:44:14, dgozman wrote:
> Let's combine this and two previous calls into
> devtools_bindings_->LoadDevTools(frontend_url, settings).

Done.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.h:235:
std::unique_ptr<Shell> secondary_window_;
On 2017/03/17 22:44:14, dgozman wrote:
> Let's call this devtools_window_ and remove one below.

Done.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
File content/shell/browser/shell_devtools_bindings.h (right):

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
content/shell/browser/shell_devtools_bindings.h:28: virtual void Close() = 0;
On 2017/03/17 22:44:14, dgozman wrote:
> You also need empty virtual destructor.

:o - thanks!

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
content/shell/browser/shell_devtools_bindings.h:53: void SetPreferences(const
std::string& json);
On 2017/03/17 22:44:14, dgozman wrote:
> This should be protected.

Done.

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
File content/shell/browser/shell_devtools_frontend.h (right):

https://codereview.chromium.org/2756623002/diff/80001/content/shell/browser/s...
content/shell/browser/shell_devtools_frontend.h:19: class ShellDevToolsFrontend
: ShellDevToolsDelegate {
On 2017/03/17 22:44:14, dgozman wrote:
> : public ShellDevToolsDelegate

Done.

[dgozman, 2017-03-20 22:40:23]

I think we can simplify this a bit more, wdyt?

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:497:
devtools_bindings_.reset();
First reset bindings, as they use WebContents from window.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:589:
devtools_bindings_.reset();
Same here - reset bindings before destroying main window.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:833: if
(devtools_bindings_)
We can just destroy bindings here.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
File content/shell/browser/shell_devtools_bindings.h (right):

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/shell_devtools_bindings.h:29: virtual
~ShellDevToolsDelegate(){};
style: space before {}

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/shell_devtools_bindings.h:47: WebContents*
devtools_contents() const { return devtools_contents_; }
These two seem to be unused.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
File content/shell/browser/shell_devtools_frontend.cc (right):

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/shell_devtools_frontend.cc:36:
shell->LoadURL(GetFrontendURL());
Perhaps we can merge the constructor and LoadDevTools method of bindings and
pass settings+url to constructor? That should also eliminate the need for
CreateFrontendHost method.

[chenwilliam, 2017-03-21 18:17:29]

ptal

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:497:
devtools_bindings_.reset();
On 2017/03/20 22:40:22, dgozman wrote:
> First reset bindings, as they use WebContents from window.

Done.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:589:
devtools_bindings_.reset();
On 2017/03/20 22:40:22, dgozman wrote:
> Same here - reset bindings before destroying main window.

Done.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/layout_test/blink_test_controller.cc:833: if
(devtools_bindings_)
On 2017/03/20 22:40:22, dgozman wrote:
> We can just destroy bindings here.

Done.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
File content/shell/browser/shell_devtools_bindings.h (right):

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/shell_devtools_bindings.h:29: virtual
~ShellDevToolsDelegate(){};
On 2017/03/20 22:40:22, dgozman wrote:
> style: space before {}

clang-format styles it like this.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/shell_devtools_bindings.h:47: WebContents*
devtools_contents() const { return devtools_contents_; }
On 2017/03/20 22:40:22, dgozman wrote:
> These two seem to be unused.

Done.

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
File content/shell/browser/shell_devtools_frontend.cc (right):

https://codereview.chromium.org/2756623002/diff/120001/content/shell/browser/...
content/shell/browser/shell_devtools_frontend.cc:36:
shell->LoadURL(GetFrontendURL());
On 2017/03/20 22:40:22, dgozman wrote:
> Perhaps we can merge the constructor and LoadDevTools method of bindings and
> pass settings+url to constructor? That should also eliminate the need for
> CreateFrontendHost method.

Done.

[dgozman, 2017-03-21 20:57:35]

lgtm

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
File content/shell/browser/shell_devtools_bindings.cc (left):

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
content/shell/browser/shell_devtools_bindings.cc:167: void
ShellDevToolsFrontend::RenderViewCreated(
We still need this in case RenderFrameHost for main frame has changed. Since we
load in constructor, it should be safe.

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
File content/shell/browser/shell_devtools_bindings.cc (right):

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
content/shell/browser/shell_devtools_bindings.cc:151: delete this;
Deleting this while being owned via std::unique_ptr is dangerous. Let's just
clear agent_host_.

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
File content/shell/browser/shell_devtools_frontend.h (right):

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
content/shell/browser/shell_devtools_frontend.h:30: protected:
Could all private now.

[chenwilliam, 2017-03-21 23:36:43]

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
File content/shell/browser/shell_devtools_bindings.cc (left):

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
content/shell/browser/shell_devtools_bindings.cc:167: void
ShellDevToolsFrontend::RenderViewCreated(
On 2017/03/21 20:57:35, dgozman wrote:
> We still need this in case RenderFrameHost for main frame has changed. Since
we
> load in constructor, it should be safe.

Done.

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
File content/shell/browser/shell_devtools_bindings.cc (right):

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
content/shell/browser/shell_devtools_bindings.cc:151: delete this;
On 2017/03/21 20:57:35, dgozman wrote:
> Deleting this while being owned via std::unique_ptr is dangerous. Let's just
> clear agent_host_.

Done.

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
File content/shell/browser/shell_devtools_frontend.h (right):

https://codereview.chromium.org/2756623002/diff/160001/content/shell/browser/...
content/shell/browser/shell_devtools_frontend.h:30: protected:
On 2017/03/21 20:57:35, dgozman wrote:
> Could all private now.

Done.

[chenwilliam, 2017-03-21 23:36:48]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-03-21 23:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2756623002/#ps200001
(title: "fix")

[commit-bot: I haz the power, 2017-03-21 23:37:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 00:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:37:34]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chenwilliam, 2017-03-22 19:19:26]

I had to undo moving LoadDevTools work into constructor (e.g. similar to PS#7)
because I noticed a handful of tests were failing. I believe this is because I
was doing virtual function calls inside a constructor.

[chenwilliam, 2017-03-22 19:19:35]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-03-22 19:19:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2756623002/#ps240001
(title: "fu")

[commit-bot: I haz the power, 2017-03-22 19:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:50:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:50:28]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chenwilliam, 2017-03-22 21:52:35]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:53:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:17:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:17:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chenwilliam, 2017-03-23 22:02:56]

The CQ bit was checked by chenwilliam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 22:04:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 23:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 23:15:24]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[chenwilliam, 2017-03-23 23:58:18]

The CQ bit was checked by chenwilliam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 23:58:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:43:02]

Dry run: This issue passed the CQ dry run.

[chenwilliam, 2017-03-24 01:54:25]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-03-24 01:54:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2756623002/#ps280001
(title: "fixup")

[commit-bot: I haz the power, 2017-03-24 01:55:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 02:01:11]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1490320465044680,
"parent_rev": "7b18bce3ebb322c2a5f7a665d24a6a0de70ba4d8", "commit_rev":
"fed5bda99ca38b4e2575614c87e858f51b2a8194"}

[commit-bot: I haz the power, 2017-03-24 02:02:00]

Description was changed from

==========
DevTools: extract bindings from ShellDevToolsFrontend

Our goal is to enable running a subset of new devtools tests so that
devtools is the main window under test and the inspected page is the
secondary window. However, our existing devtools tests currently have
the inspected page as the main window which then triggers opening devtools.

Since we'll need to run both our existing and new type of tests, we want
to create a way of flexibly binding the devtools and inspected windows.

After this CL lands:
* Implement the new type of devtools test where devtools is the main window
* Convert existing tests into the new type of tests
* Once everything has been converted, clean up test infra code for 
the old type of tests

BUG=667560
==========

to

==========
DevTools: extract bindings from ShellDevToolsFrontend

Our goal is to enable running a subset of new devtools tests so that
devtools is the main window under test and the inspected page is the
secondary window. However, our existing devtools tests currently have
the inspected page as the main window which then triggers opening devtools.

Since we'll need to run both our existing and new type of tests, we want
to create a way of flexibly binding the devtools and inspected windows.

After this CL lands:
* Implement the new type of devtools test where devtools is the main window
* Convert existing tests into the new type of tests
* Once everything has been converted, clean up test infra code for 
the old type of tests

BUG=667560

Review-Url: https://codereview.chromium.org/2756623002
Cr-Commit-Position: refs/heads/master@{#459337}
Committed:
https://chromium.googlesource.com/chromium/src/+/fed5bda99ca38b4e2575614c87e8...
==========

[commit-bot: I haz the power, 2017-03-24 02:02:02]

Committed patchset #15 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/fed5bda99ca38b4e2575614c87e8...