Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Side by Side Diff: content/shell/browser/layout_test/layout_test_devtools_bindings.h

Issue 2756623002: DevTools: extract bindings from ShellDevToolsFrontend (Closed)
Patch Set: fixup Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_ 5 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_BINDINGS_H_
6 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_ 6 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_BINDINGS_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "content/shell/browser/shell_devtools_frontend.h" 10 #include "content/shell/browser/shell_devtools_frontend.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 class Shell;
15 class WebContents; 14 class WebContents;
16 15
17 class LayoutTestDevToolsFrontend : public ShellDevToolsFrontend { 16 class LayoutTestDevToolsBindings : public ShellDevToolsBindings {
18 public: 17 public:
19 static LayoutTestDevToolsFrontend* Show(WebContents* inspected_contents, 18 LayoutTestDevToolsBindings(WebContents* devtools_contents,
20 const std::string& settings, 19 WebContents* inspected_contents);
21 const std::string& frontend_url);
22 20
23 static GURL GetDevToolsPathAsURL(const std::string& frontend_url); 21 static GURL GetDevToolsPathAsURL(const std::string& frontend_url);
24 22
25 static GURL MapJSTestURL(const GURL& test_url); 23 static GURL MapJSTestURL(const GURL& test_url);
26 24
27 void ReuseFrontend(const std::string& settings, 25 void LoadDevTools(const std::string& settings,
28 const std::string frontend_url); 26 const std::string& frontend_url);
29 void EvaluateInFrontend(int call_id, const std::string& expression); 27 void EvaluateInFrontend(int call_id, const std::string& expression);
30 28
29 ~LayoutTestDevToolsBindings() override;
30
31 private: 31 private:
32 LayoutTestDevToolsFrontend(Shell* frontend_shell, 32 // ShellDevToolsBindings overrides.
33 WebContents* inspected_contents);
34 ~LayoutTestDevToolsFrontend() override;
35
36 // content::DevToolsAgentHostClient implementation.
37 void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override;
38
39 // ShellDevToolsFrontend overrides.
40 void HandleMessageFromDevToolsFrontend(const std::string& message) override; 33 void HandleMessageFromDevToolsFrontend(const std::string& message) override;
41 34
42 // WebContentsObserver implementation. 35 // WebContentsObserver implementation.
43 void RenderProcessGone(base::TerminationStatus status) override; 36 void RenderProcessGone(base::TerminationStatus status) override;
44 void RenderFrameCreated(RenderFrameHost* render_frame_host) override; 37 void RenderFrameCreated(RenderFrameHost* render_frame_host) override;
45 38
46 bool ready_for_test_; 39 bool ready_for_test_;
47 std::vector<std::pair<int, std::string>> pending_evaluations_; 40 std::vector<std::pair<int, std::string>> pending_evaluations_;
48 41
49 DISALLOW_COPY_AND_ASSIGN(LayoutTestDevToolsFrontend); 42 DISALLOW_COPY_AND_ASSIGN(LayoutTestDevToolsBindings);
50 }; 43 };
51 44
52 } // namespace content 45 } // namespace content
53 46
54 #endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_FRONTEND_H_ 47 #endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_DEVTOOLS_BINDINGS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698