Allow SpdySessionPool to find/create SpdySession with IP pooling disabled.

Allow SpdySessionPool to find/create SpdySession with IP pooling disabled.

This is in preparation to support HTTP response status 421 Misdirected
Request, when the client may retry the request on a different
connection, preferably on one with IP based pooling disabled.

* Add |enable_ip_based_pooling| argument to
  SpdySessionPool::FindAvailableSession().
* Remove previously IP pooled session from
  SpdySessionPool::available_sessions_, SpdySessionPool::aliases_, and
  remove key from SpdySession::pooled_aliases, so that a new SpdySession
  can be created with the same key.
* Add unittest; add test helper method.

BUG=546991
Review-Url: https://codereview.chromium.org/2756503002
Cr-Commit-Position: refs/heads/master@{#457290}
Committed: https://chromium.googlesource.com/chromium/src/+/9ead3ae7b5e197e2d1fdd6d78036f5aa072c0a74

[Bence, 2017-03-15 18:31:26]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 18:32:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 20:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:03:33]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-03-15 23:58:01]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2017-03-15 23:58:01]

Ryan: PTAL.  This might work just as fine as https://crrev.com/2749123002, but
it's a ton simpler.

[Ryan Hamilton, 2017-03-16 00:18:29]

lgtm

Wow, that is much simpler. I love it! Great catch.

[Bence, 2017-03-16 00:41:45]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:42:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:48:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489624905609400, "parent_rev":
"67c474ece410fa989161d7043b0e0ae14e97855a", "commit_rev":
"9ead3ae7b5e197e2d1fdd6d78036f5aa072c0a74"}

[commit-bot: I haz the power, 2017-03-16 00:49:24]

Description was changed from

==========
Allow SpdySessionPool to find/create SpdySession with IP pooling disabled.

This is in preparation to support HTTP response status 421 Misdirected
Request, when the client may retry the request on a different
connection, preferably on one with IP based pooling disabled.

* Add |enable_ip_based_pooling| argument to
  SpdySessionPool::FindAvailableSession().
* Remove previously IP pooled session from
  SpdySessionPool::available_sessions_, SpdySessionPool::aliases_, and
  remove key from SpdySession::pooled_aliases, so that a new SpdySession
  can be created with the same key.
* Add unittest; add test helper method.

BUG=546991
==========

to

==========
Allow SpdySessionPool to find/create SpdySession with IP pooling disabled.

This is in preparation to support HTTP response status 421 Misdirected
Request, when the client may retry the request on a different
connection, preferably on one with IP based pooling disabled.

* Add |enable_ip_based_pooling| argument to
  SpdySessionPool::FindAvailableSession().
* Remove previously IP pooled session from
  SpdySessionPool::available_sessions_, SpdySessionPool::aliases_, and
  remove key from SpdySession::pooled_aliases, so that a new SpdySession
  can be created with the same key.
* Add unittest; add test helper method.

BUG=546991

Review-Url: https://codereview.chromium.org/2756503002
Cr-Commit-Position: refs/heads/master@{#457290}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ead3ae7b5e197e2d1fdd6d78036...
==========

[commit-bot: I haz the power, 2017-03-16 00:49:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ead3ae7b5e197e2d1fdd6d78036...