Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: net/spdy/spdy_session_pool.h

Issue 2756503002: Allow SpdySessionPool to find/create SpdySession with IP pooling disabled. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_session_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session_pool.h
diff --git a/net/spdy/spdy_session_pool.h b/net/spdy/spdy_session_pool.h
index fc82c40cc39b38ea2e99cf740b5d320f34e7d97d..9da2fb7a26be07f2a04e1c847fd38cc631886b82 100644
--- a/net/spdy/spdy_session_pool.h
+++ b/net/spdy/spdy_session_pool.h
@@ -87,12 +87,19 @@ class NET_EXPORT SpdySessionPool
const NetLogWithSource& net_log,
bool is_secure);
- // Return an available session for |key| that has an unclaimed push stream for
- // |url| if such exists and |url| is not empty, or else an available session
- // for |key| if such exists, or else nullptr.
+ // If |url| is not empty and there is a session for |key| that has an
+ // unclaimed push stream for |url|, return it.
+ // Otherwise if there is an available session for |key|, return it.
+ // Otherwise if there is a session to pool to based on IP address:
+ // * if |enable_ip_based_pooling == true|,
+ // then mark it as available for |key| and return it;
+ // * if |enable_ip_based_pooling == false|,
+ // then remove it from the available sessions, and return nullptr.
+ // Otherwise return nullptr.
base::WeakPtr<SpdySession> FindAvailableSession(
const SpdySessionKey& key,
const GURL& url,
+ bool enable_ip_based_pooling,
const NetLogWithSource& net_log);
// Remove all mappings and aliases for the given session, which must
« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_session_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698