Chromium Code Reviews
Help | Chromium Project | Sign in
(71)

Issue 2756423002: [Password Generation] Don't send generation vote if the vote is uploaded for another form (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 10 hours ago by kolos1
Modified:
3 days, 14 hours ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Don't send generation vote if the vote is uploaded for another form Before this CL, ACCOUNT_CREATION votes are uploaded for the saved credentials, but not for the observed form. The generation vote is a vote about the observed form. Therefore, don't send the generation vote if |password_type| is equal to ACCOUNT_CREATION. BUG=552420 Review-Url: https://codereview.chromium.org/2756423002 Cr-Commit-Position: refs/heads/master@{#458338} Committed: https://chromium.googlesource.com/chromium/src/+/aaf64ecd8fdbdf8e35f6c7bfe5706df02b777a62

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 15 (10 generated)
kolos1
4 days, 10 hours ago (2017-03-20 11:02:38 UTC) #2
kolos1
Fixed. Now don't send generation votes only for ACCOUNT_CREATION uploads (NOT_ACCOUNT_CREATION was excluded).
4 days, 8 hours ago (2017-03-20 13:29:49 UTC) #5
dvadym
LGTM. Thanks for fixing this!
4 days, 8 hours ago (2017-03-20 13:34:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756423002/40001
3 days, 14 hours ago (2017-03-21 07:18:16 UTC) #12
commit-bot: I haz the power
3 days, 14 hours ago (2017-03-21 07:23:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aaf64ecd8fdbdf8e35f6c7bfe570...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62