[Password Generation] Don't send generation vote if the vote is uploaded for another form

[Password Generation] Don't send generation vote if the vote is uploaded for another form

Before this CL, ACCOUNT_CREATION votes are uploaded for the saved credentials, but not for the observed form. The generation vote is a vote about the observed form. Therefore, don't send the generation vote if |password_type| is equal to ACCOUNT_CREATION.

BUG=552420
Review-Url: https://codereview.chromium.org/2756423002
Cr-Commit-Position: refs/heads/master@{#458338}
Committed: https://chromium.googlesource.com/chromium/src/+/aaf64ecd8fdbdf8e35f6c7bfe5706df02b777a62

[kolos1, 2017-03-20 11:02:37]

kolos@chromium.org changed reviewers:
+ dvadym@chromium.org

[kolos1, 2017-03-20 13:26:27]

Patchset #2 (id:20001) has been deleted

[kolos1, 2017-03-20 13:28:57]

Description was changed from

==========
[Password Generation] Don't send generation vote if the vote is uploaded for
another form

Before this CL, ACCOUNT_CREATION and NOT_ACCOUNT_CREATION votes are uploaded for
the saved credentials (but not for the observed form). The generation vote is a
vote about the observed form. Therefore, don't send the genration vote if
|password_type| is equal to ACCOUNT_CREATION or NOT_ACCOUNT_CREATION.

BUG=552420
==========

to

==========
[Password Generation] Don't send generation vote if the vote is uploaded for
another form

Before this CL, ACCOUNT_CREATION votes are uploaded for the saved credentials,
but not for the observed form. The generation vote is a vote about the observed
form. Therefore, don't send the generation vote if |password_type| is equal to
ACCOUNT_CREATION.

BUG=552420
==========

[kolos1, 2017-03-20 13:29:49]

Fixed. Now don't send generation votes only for ACCOUNT_CREATION uploads
(NOT_ACCOUNT_CREATION was excluded).

[dvadym, 2017-03-20 13:34:06]

LGTM. Thanks for fixing this!

[kolos1, 2017-03-20 13:39:32]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 13:39:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 14:52:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 14:52:16]

Dry run: This issue passed the CQ dry run.

[kolos1, 2017-03-21 07:17:57]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2017-03-21 07:18:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 07:22:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490080677970820,
"parent_rev": "115df74bcb6e64fdde621c61f95c2531e4710ee2", "commit_rev":
"aaf64ecd8fdbdf8e35f6c7bfe5706df02b777a62"}

[commit-bot: I haz the power, 2017-03-21 07:23:35]

Description was changed from

==========
[Password Generation] Don't send generation vote if the vote is uploaded for
another form

Before this CL, ACCOUNT_CREATION votes are uploaded for the saved credentials,
but not for the observed form. The generation vote is a vote about the observed
form. Therefore, don't send the generation vote if |password_type| is equal to
ACCOUNT_CREATION.

BUG=552420
==========

to

==========
[Password Generation] Don't send generation vote if the vote is uploaded for
another form

Before this CL, ACCOUNT_CREATION votes are uploaded for the saved credentials,
but not for the observed form. The generation vote is a vote about the observed
form. Therefore, don't send the generation vote if |password_type| is equal to
ACCOUNT_CREATION.

BUG=552420

Review-Url: https://codereview.chromium.org/2756423002
Cr-Commit-Position: refs/heads/master@{#458338}
Committed:
https://chromium.googlesource.com/chromium/src/+/aaf64ecd8fdbdf8e35f6c7bfe570...
==========

[commit-bot: I haz the power, 2017-03-21 07:23:36]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aaf64ecd8fdbdf8e35f6c7bfe570...