Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2755883002: Revert of Fix the condensed NTP layout for tablets. (Closed)

Created:
3 years, 9 months ago by cblume
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix the condensed NTP layout for tablets. (patchset #2 id:20001 of https://codereview.chromium.org/2750503008/ ) Reason for revert: This is causing KitKat Tablet Tester to fail the chrome_public_test_apk step. Original issue's description: > Fix the condensed NTP layout for tablets. > > BUG=700947 > > Review-Url: https://codereview.chromium.org/2750503008 > Cr-Commit-Position: refs/heads/master@{#457068} > Committed: https://chromium.googlesource.com/chromium/src/+/aa26b1a2d7c80e970051ee002dd072f37f9a3852 TBR=bauerb@chromium.org,mvanouwerkerk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700947 Review-Url: https://codereview.chromium.org/2755883002 Cr-Commit-Position: refs/heads/master@{#457362} Committed: https://chromium.googlesource.com/chromium/src/+/5095480ec3cb9b572e9a14f9d4a93f9d0b54b992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
cblume
Created Revert of Fix the condensed NTP layout for tablets.
3 years, 9 months ago (2017-03-16 06:08:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755883002/1
3 years, 9 months ago (2017-03-16 06:09:01 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-16 06:09:02 UTC) #5
aelias_OOO_until_Jul13
lgtm
3 years, 9 months ago (2017-03-16 06:09:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755883002/1
3 years, 9 months ago (2017-03-16 06:09:31 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 06:11:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5095480ec3cb9b572e9a14f9d4a9...

Powered by Google App Engine
This is Rietveld 408576698