Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2750503008:
Fix the condensed NTP layout for tablets. (Closed)
|
Created:
3 years, 9 months ago by Michael van Ouwerkerk Modified:
3 years, 9 months ago Reviewers:
Bernhard Bauer CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix the condensed NTP layout for tablets.
BUG=700947
Review-Url: https://codereview.chromium.org/2750503008
Cr-Commit-Position: refs/heads/master@{#457068}
Committed: https://chromium.googlesource.com/chromium/src/+/aa26b1a2d7c80e970051ee002dd072f37f9a3852
Patch Set 1 #
Total comments: 2
Patch Set 2 : comment #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run
mvanouwerkerk@chromium.org changed reviewers: + bauerb@chromium.org
Bernhard, could you take a look please?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. Can you take some screenshots of various configurations (e.g. landscape / portrait; maybe scroll a bit as well) and post them on the bug for verification? https://codereview.chromium.org/2750503008/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java (right): https://codereview.chromium.org/2750503008/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:309: // If the little G should not be shown then clear it because it is shown by default in xml. Nit: "Google G" to make it clear which G we're talking about? :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2750503008/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java (right): https://codereview.chromium.org/2750503008/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:309: // If the little G should not be shown then clear it because it is shown by default in xml. On 2017/03/14 15:32:28, Bernhard Bauer wrote: > Nit: "Google G" to make it clear which G we're talking about? :) Done.
The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mvanouwerkerk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org Link to the patchset: https://codereview.chromium.org/2750503008/#ps20001 (title: "comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489584625452750,
"parent_rev": "cdfbf3ba453a5c0d9c67a4d793f1b2cd01ea7393", "commit_rev":
"aa26b1a2d7c80e970051ee002dd072f37f9a3852"}
Message was sent while issue was closed.
Description was changed from ========== Fix the condensed NTP layout for tablets. BUG=700947 ========== to ========== Fix the condensed NTP layout for tablets. BUG=700947 Review-Url: https://codereview.chromium.org/2750503008 Cr-Commit-Position: refs/heads/master@{#457068} Committed: https://chromium.googlesource.com/chromium/src/+/aa26b1a2d7c80e970051ee002dd0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/aa26b1a2d7c80e970051ee002dd0...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2755883002/ by cblume@chromium.org. The reason for reverting is: This is causing KitKat Tablet Tester to fail the chrome_public_test_apk step.. |
