Improve FirstMeaningfulPaintDetectorTest's timer tests

Improve FirstMeaningfulPaintDetectorTest's timer tests

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.
Now it verifies that the timers are actually fired.

This also changes other test cases to use mock timer provided by
TestingPlatformSupportWithMockScheduler.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2755873002
Cr-Commit-Position: refs/heads/master@{#457394}
Committed: https://chromium.googlesource.com/chromium/src/+/e9c1c98d51c7b2bb74f58da335aa75bdb128cd89

[Kunihiko Sakamoto, 2017-03-16 06:01:37]

Description was changed from

==========
WIP
==========

to

==========
WIP
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Kunihiko Sakamoto, 2017-03-16 06:01:46]

The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 06:01:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 06:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 06:30:48]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Kunihiko Sakamoto, 2017-03-16 07:50:24]

The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 07:50:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kunihiko Sakamoto, 2017-03-16 08:25:38]

Patchset #1 (id:1) has been deleted

[Kunihiko Sakamoto, 2017-03-16 08:36:27]

Description was changed from

==========
WIP
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Improve FirstMeaningfulPaintDetectorTest's timer tests

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Kunihiko Sakamoto, 2017-03-16 09:04:51]

Description was changed from

==========
Improve FirstMeaningfulPaintDetectorTest's timer tests

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Improve FirstMeaningfulPaintDetectorTest's timer tests

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.
Now it verifies that the timers are actually fired.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Kunihiko Sakamoto, 2017-03-16 09:06:47]

Description was changed from

==========
Improve FirstMeaningfulPaintDetectorTest's timer tests

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.
Now it verifies that the timers are actually fired.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Improve FirstMeaningfulPaintDetectorTest's timer tests

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.
Now it verifies that the timers are actually fired.

This also changes other test cases to use mock timer provided by
TestingPlatformSupportWithMockScheduler.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Kunihiko Sakamoto, 2017-03-16 09:07:25]

ksakamoto@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2017-03-16 09:21:12]

lgtm

https://codereview.chromium.org/2755873002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp
(right):

https://codereview.chromium.org/2755873002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp:23:
m_platform->advanceClockSeconds(0.001);
why 0.001? make this larger?

[Kunihiko Sakamoto, 2017-03-16 09:26:41]

https://codereview.chromium.org/2755873002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp
(right):

https://codereview.chromium.org/2755873002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp:23:
m_platform->advanceClockSeconds(0.001);
On 2017/03/16 09:21:12, kouhei wrote:
> why 0.001? make this larger?

No specific reason - changed to 1.

[Kunihiko Sakamoto, 2017-03-16 09:26:46]

The CQ bit was checked by ksakamoto@chromium.org

[Kunihiko Sakamoto, 2017-03-16 09:26:46]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2755873002/#ps40001
(title: "0.001 -> 1")

[commit-bot: I haz the power, 2017-03-16 09:27:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 11:02:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489656406640850,
"parent_rev": "af861c1f7d2bfe863febea4fd6a5d14483c30b48", "commit_rev":
"e9c1c98d51c7b2bb74f58da335aa75bdb128cd89"}

[commit-bot: I haz the power, 2017-03-16 11:03:33]

Description was changed from

==========
Improve FirstMeaningfulPaintDetectorTest's timer tests

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.
Now it verifies that the timers are actually fired.

This also changes other test cases to use mock timer provided by
TestingPlatformSupportWithMockScheduler.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Improve FirstMeaningfulPaintDetectorTest's timer tests

This rewrites FirstMeaningfulPaintDetectorTest's test case for the
network quiet timers, using TestingPlatformSupportWithMockScheduler.
Now it verifies that the timers are actually fired.

This also changes other test cases to use mock timer provided by
TestingPlatformSupportWithMockScheduler.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2755873002
Cr-Commit-Position: refs/heads/master@{#457394}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9c1c98d51c7b2bb74f58da335aa...
==========

[commit-bot: I haz the power, 2017-03-16 11:03:34]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e9c1c98d51c7b2bb74f58da335aa...