third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp - Issue 2755873002: Improve FirstMeaningfulPaintDetectorTest's timer tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

Issue 2755873002: Improve FirstMeaningfulPaintDetectorTest's timer tests (Closed)

Patch Set: 0.001 -> 1 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h ('k') | third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

index 34ab1db5ed5de7ecf31e483898b2558cdd30c748..6c203a14c8f0de1b9dc47771f7f93a6bdf46020a 100644

--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

@@ -19,11 +19,6 @@ namespace {

// Meaningful Paint.

const int kBlankCharactersThreshold = 200;

-// The page is n-quiet if there are no more than n active network requests for

-// this duration of time.

-const double kNetwork2QuietWindowSeconds = 3;

-const double kNetwork0QuietWindowSeconds = 0.5;

} // namespace

FirstMeaningfulPaintDetector& FirstMeaningfulPaintDetector::from(