Disable all non-average summary statistics in tracing_metric.html

Disable all non-average summary statistics in tracing_metric.html

Given that all histograms only have one sample and all tests were only
looking at the average summary statistic, this serves no other purpose
other than to help clean up the list of metrics in the dashboard.

(I also added a missing description to the trace duration metric in this
same CL - hopefully that's okay.)

TBR=benjhayden@chromium.org

Review-Url: https://codereview.chromium.org/2755863003
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/04f8d38d9d74e8558757fd724b227ae77e53e42f

[charliea (OOO until 10-5), 2017-03-16 19:09:36]

Patchset #1 (id:1) has been deleted

[charliea (OOO until 10-5), 2017-03-16 19:10:30]

charliea@chromium.org changed reviewers:
+ eakuefner@chromium.org

[charliea (OOO until 10-5), 2017-03-16 19:10:30]

charliea@chromium.org changed required reviewers:
+ eakuefner@chromium.org

[charliea (OOO until 10-5), 2017-03-16 19:10:53]

charliea@chromium.org changed reviewers:
+ tdresser@chromium.org
- eakuefner@chromium.org

[charliea (OOO until 10-5), 2017-03-16 19:10:53]

charliea@chromium.org changed required reviewers:
+ tdresser@chromium.org
- eakuefner@chromium.org

[charliea (OOO until 10-5), 2017-03-16 19:10:54]

Swapping out eakuefner@ with tdresser@ based on Ethan's CL load

[tdresser, 2017-03-16 19:44:09]

LGTM with vaguely relevant question.

https://codereview.chromium.org/2755863003/diff/20001/tracing/tracing/metrics...
File tracing/tracing/metrics/tracing_metric.html (right):

https://codereview.chromium.org/2755863003/diff/20001/tracing/tracing/metrics...
tracing/tracing/metrics/tracing_metric.html:115: 'Average trace size of
memory-infra dumps in bytes';
eslint currently verifies that these are present, but only on new code correct?
So the reason this needed to be added is that we never went back and added ;'s
to old code?

[charliea (OOO until 10-5), 2017-03-16 20:16:29]

https://codereview.chromium.org/2755863003/diff/20001/tracing/tracing/metrics...
File tracing/tracing/metrics/tracing_metric.html (right):

https://codereview.chromium.org/2755863003/diff/20001/tracing/tracing/metrics...
tracing/tracing/metrics/tracing_metric.html:115: 'Average trace size of
memory-infra dumps in bytes';
On 2017/03/16 19:44:09, tdresser wrote:
> eslint currently verifies that these are present, but only on new code
correct?
> So the reason this needed to be added is that we never went back and added ;'s
> to old code?
> 

Nope: I actually have absolutely no reason why this is the case. When doing the
presubmit checks, eslint is only run on the files that are touched. However,
when enabling new eslint rules, we regularly run it on the whole codebase with
--fix

$ common/eslint/bin/run_eslint --all --extra-args="--fix"

which should look at all code, not only new code, and fix any problems. Somehow,
this must be some case that's not checked by eslint. I wonder if they know about
it?

[tdresser, 2017-03-16 20:24:20]

https://codereview.chromium.org/2755863003/diff/20001/tracing/tracing/metrics...
File tracing/tracing/metrics/tracing_metric.html (right):

https://codereview.chromium.org/2755863003/diff/20001/tracing/tracing/metrics...
tracing/tracing/metrics/tracing_metric.html:115: 'Average trace size of
memory-infra dumps in bytes';
On 2017/03/16 20:16:28, charliea wrote:
> On 2017/03/16 19:44:09, tdresser wrote:
> > eslint currently verifies that these are present, but only on new code
> correct?
> > So the reason this needed to be added is that we never went back and added
;'s
> > to old code?
> > 
> 
> Nope: I actually have absolutely no reason why this is the case. When doing
the
> presubmit checks, eslint is only run on the files that are touched. However,
> when enabling new eslint rules, we regularly run it on the whole codebase with
> --fix
> 
> $ common/eslint/bin/run_eslint --all --extra-args="--fix"
> 
> which should look at all code, not only new code, and fix any problems.
Somehow,
> this must be some case that's not checked by eslint. I wonder if they know
about
> it?

Interesting. Must be a fairly complicated repro - eslint is doing fine on the
minimized test case I tried.

[charliea (OOO until 10-5), 2017-03-20 18:21:05]

The CQ bit was checked by charliea@chromium.org

[commit-bot: I haz the power, 2017-03-20 18:21:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 18:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 18:21:11]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-catapult-committers".
Note that this has nothing to do with OWNERS files.

[charliea (OOO until 10-5), 2017-03-21 12:47:49]

Description was changed from

==========
Disable all non-average summary statistics in tracing_metric.html

Given that all histograms only have one sample and all tests were only
looking at the average summary statistic, this serves no other purpose
other than to help clean up the list of metrics in the dashboard.

(I also added a missing description to the trace duration metric in this
same CL - hopefully that's okay.)
==========

to

==========
Disable all non-average summary statistics in tracing_metric.html

Given that all histograms only have one sample and all tests were only
looking at the average summary statistic, this serves no other purpose
other than to help clean up the list of metrics in the dashboard.

(I also added a missing description to the trace duration metric in this
same CL - hopefully that's okay.)

TBR=benjhayden@chromium.org
==========

[charliea (OOO until 10-5), 2017-03-21 12:47:49]

charliea@chromium.org changed reviewers:
+ benjhayden@chromium.org

[charliea (OOO until 10-5), 2017-03-21 12:48:11]

(TBRing Ben while Tim gets committer status)

[charliea (OOO until 10-5), 2017-03-21 12:48:14]

The CQ bit was checked by charliea@chromium.org

[commit-bot: I haz the power, 2017-03-21 12:48:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[charliea (OOO until 10-5), 2017-03-21 13:06:02]

The CQ bit was unchecked by charliea@chromium.org

[charliea (OOO until 10-5), 2017-03-21 13:06:23]

As per Tim's request, I'm going to try this without TBRing Ben to check if Tim
has the correct permissions now.

[charliea (OOO until 10-5), 2017-03-21 13:06:36]

charliea@chromium.org changed reviewers:
- benjhayden@chromium.org

[charliea (OOO until 10-5), 2017-03-21 13:06:40]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2017-03-21 13:06:46]

Description was changed from

==========
Disable all non-average summary statistics in tracing_metric.html

Given that all histograms only have one sample and all tests were only
looking at the average summary statistic, this serves no other purpose
other than to help clean up the list of metrics in the dashboard.

(I also added a missing description to the trace duration metric in this
same CL - hopefully that's okay.)

TBR=benjhayden@chromium.org
==========

to

==========
Disable all non-average summary statistics in tracing_metric.html

Given that all histograms only have one sample and all tests were only
looking at the average summary statistic, this serves no other purpose
other than to help clean up the list of metrics in the dashboard.

(I also added a missing description to the trace duration metric in this
same CL - hopefully that's okay.)
==========

[commit-bot: I haz the power, 2017-03-21 13:06:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[charliea (OOO until 10-5), 2017-03-21 13:06:50]

The CQ bit was unchecked by charliea@chromium.org

[charliea (OOO until 10-5), 2017-03-21 13:06:54]

The CQ bit was checked by charliea@chromium.org

[commit-bot: I haz the power, 2017-03-21 13:06:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 13:10:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490101614205660,
"parent_rev": "73de308284a8f86bc8d350c677dcc2fe59325171", "commit_rev":
"04f8d38d9d74e8558757fd724b227ae77e53e42f"}

[commit-bot: I haz the power, 2017-03-21 13:10:56]

Description was changed from

==========
Disable all non-average summary statistics in tracing_metric.html

Given that all histograms only have one sample and all tests were only
looking at the average summary statistic, this serves no other purpose
other than to help clean up the list of metrics in the dashboard.

(I also added a missing description to the trace duration metric in this
same CL - hopefully that's okay.)

TBR=benjhayden@chromium.org
==========

to

==========
Disable all non-average summary statistics in tracing_metric.html

Given that all histograms only have one sample and all tests were only
looking at the average summary statistic, this serves no other purpose
other than to help clean up the list of metrics in the dashboard.

(I also added a missing description to the trace duration metric in this
same CL - hopefully that's okay.)

TBR=benjhayden@chromium.org

Review-Url: https://codereview.chromium.org/2755863003
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-03-21 13:10:57]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...