Disable all non-average summary statistics in tracing_metric.html

tracing/tracing/metrics/tracing_metric.html

Index: tracing/tracing/metrics/tracing_metric.html
diff --git a/tracing/tracing/metrics/tracing_metric.html b/tracing/tracing/metrics/tracing_metric.html
index c3f3c8ed906cc73ba2058ea9ff2e8c3695722b9c..f4adce19bab5a3f0b17ac606a0e7e1fd61e416c2 100644
--- a/tracing/tracing/metrics/tracing_metric.html
+++ b/tracing/tracing/metrics/tracing_metric.html
@@ -30,6 +30,14 @@ tr.exportTo('tr.metrics', function() {
     let hist = new tr.v.Histogram(histogramName,
         tr.b.Unit.byName.timeDurationInMs_smallerIsBetter, TIME_BOUNDARIES);
     hist.addSample(duration);
+    hist.customizeSummaryOptions({
+      count: false,
+      min: false,
+      max: false,
+      sum: false,
+      avg: true,
+      std: false
+    });
     histograms.addHistogram(hist);
     if (opt_description) hist.description = opt_description;
   }
@@ -89,6 +97,14 @@ tr.exportTo('tr.metrics', function() {
         tr.b.Unit.byName.sizeInBytes_smallerIsBetter, BYTE_BOUNDARIES);
     memoryInfraTraceBytesValue.description =
         'Total trace size of memory-infra dumps in bytes';
+    memoryInfraTraceBytesValue.customizeSummaryOptions({
+      count: false,
+      min: false,
+      max: false,
+      sum: false,
+      avg: true,
+      std: false
+    });
     memoryInfraTraceBytesValue.addSample(memoryInfraEventsSize);
     histograms.addHistogram(memoryInfraTraceBytesValue);
 
@@ -96,7 +112,15 @@ tr.exportTo('tr.metrics', function() {
         'memory_dump_size',
         tr.b.Unit.byName.sizeInBytes_smallerIsBetter, BYTE_BOUNDARIES);
     traceBytesPerDumpValue.description =
-        'Average trace size of memory-infra dumps in bytes',
+        'Average trace size of memory-infra dumps in bytes';

[tdresser, 2017/03/16 19:44:09]

eslint currently verifies that these are present, but only on new code correct?
So the reason this needed to be added is that we never went back and added ;'s
to old code?

[charliea (OOO until 10-5), 2017/03/16 20:16:28]

Nope: I actually have absolutely no reason why this is the case. When doing the
presubmit checks, eslint is only run on the files that are touched. However,
when enabling new eslint rules, we regularly run it on the whole codebase with
--fix

$ common/eslint/bin/run_eslint --all --extra-args="--fix"

which should look at all code, not only new code, and fix any problems. Somehow,
this must be some case that's not checked by eslint. I wonder if they know about
it?

[tdresser, 2017/03/16 20:24:20]

Interesting. Must be a fairly complicated repro - eslint is doing fine on the
minimized test case I tried.

+    traceBytesPerDumpValue.customizeSummaryOptions({
+      count: false,
+      min: false,
+      max: false,
+      sum: false,
+      avg: true,
+      std: false
+    });
     traceBytesPerDumpValue.addSample(memoryInfraEventsSize / memoryDumpCount);
     histograms.addHistogram(traceBytesPerDumpValue);
   }
@@ -108,7 +132,8 @@ tr.exportTo('tr.metrics', function() {
   // https://github.com/catapult-project/catapult/issues/3233
   function tracingMetric(histograms, model) {
     addTimeDurationHistogram(
-        'trace_import_duration', model.stats.traceImportDurationMs, histograms);
+        'trace_import_duration', model.stats.traceImportDurationMs, histograms,
+        'Duration that trace viewer required to import the trace');
 
     if (!model.stats.hasEventSizesinBytes) return;
 
@@ -174,16 +199,40 @@ tr.exportTo('tr.metrics', function() {
         'peak_event_rate', tr.b.Unit.byName.count_smallerIsBetter,
         COUNT_BOUNDARIES);
     maxEventCountPerSecValue.description = 'Max number of events per second';
+    maxEventCountPerSecValue.customizeSummaryOptions({
+      count: false,
+      min: false,
+      max: false,
+      sum: false,
+      avg: true,
+      std: false
+    });
     maxEventCountPerSecValue.addSample(maxEventCountPerSec);
 
     let maxEventBytesPerSecValue = new tr.v.Histogram(
         'peak_event_size_rate', tr.b.Unit.byName.sizeInBytes_smallerIsBetter,
         BYTE_BOUNDARIES);
     maxEventBytesPerSecValue.description = 'Max event size in bytes per second';
+    maxEventBytesPerSecValue.customizeSummaryOptions({
+      count: false,
+      min: false,
+      max: false,
+      sum: false,
+      avg: true,
+      std: false
+    });
     maxEventBytesPerSecValue.addSample(maxEventBytesPerSec);
 
     let totalTraceBytesValue = new tr.v.Histogram('trace_size',
         tr.b.Unit.byName.sizeInBytes_smallerIsBetter, BYTE_BOUNDARIES);
+    totalTraceBytesValue.customizeSummaryOptions({
+      count: false,
+      min: false,
+      max: false,
+      sum: false,
+      avg: true,
+      std: false
+    });
     totalTraceBytesValue.addSample(totalTraceBytes);
 
     let biggestCategory = {