Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2755813004: Invalidate SVG 'transform' pres. attribute style even if not attached (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Invalidate SVG 'transform' pres. attribute style even if not attached When the 'transform' attribute was manipulated via its SVG DOM representation (SVGTransformList), the presentation-attribute-style-is-dirty flag would not be set unless the element had been attached. Reorder the contents of the 'transform' branch in SVGGraphicsElement::svgAttributeChanged so that the presentation attribute style is always dirtied regardless of attachment status. BUG=701075 Review-Url: https://codereview.chromium.org/2745053005 Cr-Commit-Position: refs/heads/master@{#456696} (cherry picked from commit 8554eac989977ff9d7f82444c01a500430097919) Review-Url: https://codereview.chromium.org/2755813004 . Cr-Commit-Position: refs/branch-heads/2987@{#840} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1dd21c9d72d0ed9bc4c31f94f6a7b308e88bb20d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/svg/transforms/svgdom-manipulation-before-attach.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/svgdom-manipulation-before-attach-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fs
3 years, 9 months ago (2017-03-17 08:38:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1dd21c9d72d0ed9bc4c31f94f6a7b308e88bb20d.

Powered by Google App Engine
This is Rietveld 408576698