Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2745053005: Invalidate SVG 'transform' pres. attribute style even if not attached (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate SVG 'transform' pres. attribute style even if not attached When the 'transform' attribute was manipulated via its SVG DOM representation (SVGTransformList), the presentation-attribute-style-is-dirty flag would not be set unless the element had been attached. Reorder the contents of the 'transform' branch in SVGGraphicsElement::svgAttributeChanged so that the presentation attribute style is always dirtied regardless of attachment status. BUG=701075 Review-Url: https://codereview.chromium.org/2745053005 Cr-Commit-Position: refs/heads/master@{#456696} Committed: https://chromium.googlesource.com/chromium/src/+/8554eac989977ff9d7f82444c01a500430097919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/svg/transforms/svgdom-manipulation-before-attach.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/svgdom-manipulation-before-attach-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 9 months ago (2017-03-14 13:04:54 UTC) #4
Stephen Chennney
Good turnaround. lgtm.
3 years, 9 months ago (2017-03-14 14:07:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745053005/1
3 years, 9 months ago (2017-03-14 14:08:20 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 14:12:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8554eac989977ff9d7f82444c01a...

Powered by Google App Engine
This is Rietveld 408576698