Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2755793004: Move files in wtf/ to platform/wtf/ (Part 3). (Closed)

Created:
3 years, 9 months ago by Yuta Kitamura
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move files in wtf/ to platform/wtf/ (Part 3). The last part for files with simple dependencies. NonCopyingSort.h NotFound.h Optional.h SizeAssertions.h StaticConstructors.h Time.h TriState.h Note that test files corresponding to those headers are still left in wtf/, because it seemed hard to have unit tests in two different compilation units. BUG=691465 Review-Url: https://codereview.chromium.org/2755793004 Cr-Commit-Position: refs/heads/master@{#457678} Committed: https://chromium.googlesource.com/chromium/src/+/16ddbc9a801d1689cf110d947ebd5f680a2701c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -349 lines) Patch
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/NonCopyingSort.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/NotFound.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/Optional.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/SizeAssertions.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/StaticConstructors.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/Time.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/TriState.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/wtf/NonCopyingSort.h View 1 chunk +7 lines, -94 lines 0 comments Download
M third_party/WebKit/Source/wtf/NotFound.h View 1 chunk +7 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/wtf/Optional.h View 1 chunk +5 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/wtf/SizeAssertions.h View 1 chunk +5 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/wtf/StaticConstructors.h View 1 chunk +7 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/wtf/Time.h View 1 chunk +5 lines, -99 lines 0 comments Download
M third_party/WebKit/Source/wtf/TriState.h View 1 chunk +7 lines, -37 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (20 generated)
Yuta Kitamura
PTAL
3 years, 9 months ago (2017-03-16 06:43:53 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-16 08:27:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755793004/1
3 years, 9 months ago (2017-03-17 03:34:55 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 03:43:08 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16ddbc9a801d1689cf110d947ebd...

Powered by Google App Engine
This is Rietveld 408576698