Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 2755783002: Remove setting the pointer cursor when the context menu event is sent. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove setting the pointer cursor when the context menu event is sent. The cursor would flash when the context menu is sent if the event is preventDefaulted. With a change https://codereview.chromium.org/2637403012 this occurred more frequently because the move event would get suppressed. Ultimately I found when this code was activated in https://codereview.chromium.org/7270 and it seems it was mis-guided in being added. I've check on Windows removing this code makes everything work fine. BUG=699232 Review-Url: https://codereview.chromium.org/2755783002 Cr-Commit-Position: refs/heads/master@{#457418} Committed: https://chromium.googlesource.com/chromium/src/+/7e40fe40d19b2c766df8d860169b11e2cacd9771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
dtapuska
3 years, 9 months ago (2017-03-15 21:43:20 UTC) #2
bokan
lgtm
3 years, 9 months ago (2017-03-16 12:14:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755783002/1
3 years, 9 months ago (2017-03-16 12:14:22 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 13:37:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e40fe40d19b2c766df8d860169b...

Powered by Google App Engine
This is Rietveld 408576698