Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 7270: Linux compile fixes for webview_impl.cc (Closed)

Created:
12 years, 2 months ago by icefox::TorchMobile
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
Visibility:
Public.

Description

Wrap cursor calls with windows ifdef as cursor support only works on windows right now Fix order of initialisation warning. Add DragData #ifelse for Linux

Patch Set 1 #

Patch Set 2 : Linux compile fixes for webview_impl.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M webkit/glue/webview_impl.cc View 1 8 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
http://codereview.chromium.org/7270/diff/1/2 File webkit/glue/webview_impl.cc (right): http://codereview.chromium.org/7270/diff/1/2#newcode1281 Line 1281: kDropTargetOperation); Most of these new linux constructs look ...
12 years, 2 months ago (2008-10-13 20:30:28 UTC) #1
icefox::TorchMobile
On 2008/10/13 20:30:28, Elliot Glaysher wrote: > http://codereview.chromium.org/7270/diff/1/2 > File webkit/glue/webview_impl.cc (right): > > http://codereview.chromium.org/7270/diff/1/2#newcode1281 ...
12 years, 2 months ago (2008-10-14 14:32:01 UTC) #2
Elliot Glaysher
12 years, 2 months ago (2008-10-14 17:28:42 UTC) #3
LGTM. Committed in r3349. Please close.

Powered by Google App Engine
This is Rietveld 408576698