Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2755693002: Revert of [Telemetry] Remove code that handle --browser=any (Closed)

Created:
3 years, 9 months ago by nednguyen
Modified:
3 years, 9 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Remove code that handle --browser=any (patchset #1 id:1 of https://codereview.chromium.org/2750463004/ ) Reason for revert: Blocking catapult roll: https://github.com/catapult-project/catapult/issues/3400 Original issue's description: > [Telemetry] Remove code that handle --browser=any > > This code is supposed to be removed in https://chromiumcodereview.appspot.com/19972003 > but then temporarily added back because of https://bugs.chromium.org/p/chromium/issues/detail?id=264129 > > Review-Url: https://codereview.chromium.org/2750463004 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c11c39e5efc7277c7b241e13fbd51aff7eaa8997 TBR=perezju@chromium.org,charliea@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2755693002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/401653f99d9b0bc738308aef9f2153ee645fce48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M telemetry/telemetry/internal/browser/browser_finder.py View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of [Telemetry] Remove code that handle --browser=any
3 years, 9 months ago (2017-03-15 13:57:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755693002/1
3 years, 9 months ago (2017-03-15 13:57:40 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 14:20:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698