Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2750463004: [Telemetry] Remove code that handle --browser=any (Closed)

Created:
3 years, 9 months ago by nednguyen
Modified:
3 years, 9 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M telemetry/telemetry/internal/browser/browser_finder.py View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
nednguyen
3 years, 9 months ago (2017-03-14 02:29:53 UTC) #2
perezju
lgtm
3 years, 9 months ago (2017-03-14 09:58:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750463004/1
3 years, 9 months ago (2017-03-14 10:23:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c11c39e5efc7277c7b241e13fbd51aff7eaa8997
3 years, 9 months ago (2017-03-14 10:25:16 UTC) #13
nednguyen
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2755693002/ by nednguyen@google.com. ...
3 years, 9 months ago (2017-03-15 13:57:29 UTC) #14
sullivan
3 years, 9 months ago (2017-03-15 13:57:38 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2745283005/ by sullivan@chromium.org.

The reason for reverting is: Suspect this broke the catapult roll.

BUG=catapult:#3400.

Powered by Google App Engine
This is Rietveld 408576698