Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: chrome/browser/permissions/permission_prompt_android.h

Issue 2755593002: Remove pointer from PermissionPromptAndroid to InfoBar (Closed)
Patch Set: fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_prompt_android.h
diff --git a/chrome/browser/permissions/permission_prompt_android.h b/chrome/browser/permissions/permission_prompt_android.h
index 45c9ee6e0e6afa9d8af97379fd18bc9a768a2b94..021aaaca9ab77d7280f22400eb336d1109ee2d3b 100644
--- a/chrome/browser/permissions/permission_prompt_android.h
+++ b/chrome/browser/permissions/permission_prompt_android.h
@@ -17,10 +17,6 @@ namespace content {
class WebContents;
}
-namespace infobars {
-class InfoBar;
-}
-
class PermissionPromptAndroid : public PermissionPrompt {
public:
explicit PermissionPromptAndroid(content::WebContents* web_contents);
@@ -31,6 +27,7 @@ class PermissionPromptAndroid : public PermissionPrompt {
void Show(const std::vector<PermissionRequest*>& requests,
const std::vector<bool>& accept_state) override;
bool CanAcceptRequestUpdate() override;
+ bool HidesAutomatically() override;
void Hide() override;
bool IsVisible() override;
void UpdateAnchorPosition() override;
@@ -53,9 +50,6 @@ class PermissionPromptAndroid : public PermissionPrompt {
content::WebContents* web_contents_;
// |delegate_| is the PermissionRequestManager, which owns this object.
Delegate* delegate_;
- // |infobar_| is owned by the InfoBarService; we keep a pointer here so we can
- // ask the service to remove the infobar after it is added.
- infobars::InfoBar* infobar_;
// The current request being displayed (if any).
std::vector<PermissionRequest*> requests_;

Powered by Google App Engine
This is Rietveld 408576698