Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4478)

Unified Diff: chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc

Issue 2755593002: Remove pointer from PermissionPromptAndroid to InfoBar (Closed)
Patch Set: fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
diff --git a/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc b/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
index d06a8a337058d8edc9601a554928db23f010ab71..31b01c9c6866d4099faf2d8b82e12b6761c9c176 100644
--- a/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
+++ b/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
@@ -83,10 +83,6 @@ void GroupedPermissionInfoBarDelegate::InfoBarDismissed() {
permission_prompt_->Closing();
}
-void GroupedPermissionInfoBarDelegate::PermissionPromptDestroyed() {
- permission_prompt_ = nullptr;
-}
-
GroupedPermissionInfoBarDelegate::GroupedPermissionInfoBarDelegate(
PermissionPromptAndroid* permission_prompt,
const GURL& requesting_origin)
@@ -124,3 +120,10 @@ base::string16 GroupedPermissionInfoBarDelegate::GetButtonLabel(
return l10n_util::GetStringUTF16((button == BUTTON_OK) ? IDS_PERMISSION_ALLOW
: IDS_PERMISSION_DENY);
}
+
+bool GroupedPermissionInfoBarDelegate::EqualsDelegate(
+ infobars::InfoBarDelegate* delegate) const {
+ // The PermissionRequestManager doesn't create duplicate infobars so a pointer
+ // equality check is sufficient.
+ return this == delegate;
+}

Powered by Google App Engine
This is Rietveld 408576698