Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/permissions/permission_prompt_android.h

Issue 2755593002: Remove pointer from PermissionPromptAndroid to InfoBar (Closed)
Patch Set: fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_ 5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_
6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_ 6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
11 #include "chrome/browser/ui/permission_bubble/permission_prompt.h" 11 #include "chrome/browser/ui/permission_bubble/permission_prompt.h"
12 #include "components/content_settings/core/common/content_settings_types.h" 12 #include "components/content_settings/core/common/content_settings_types.h"
13 13
14 class PermissionRequest; 14 class PermissionRequest;
15 15
16 namespace content { 16 namespace content {
17 class WebContents; 17 class WebContents;
18 } 18 }
19 19
20 namespace infobars {
21 class InfoBar;
22 }
23
24 class PermissionPromptAndroid : public PermissionPrompt { 20 class PermissionPromptAndroid : public PermissionPrompt {
25 public: 21 public:
26 explicit PermissionPromptAndroid(content::WebContents* web_contents); 22 explicit PermissionPromptAndroid(content::WebContents* web_contents);
27 ~PermissionPromptAndroid() override; 23 ~PermissionPromptAndroid() override;
28 24
29 // PermissionPrompt: 25 // PermissionPrompt:
30 void SetDelegate(Delegate* delegate) override; 26 void SetDelegate(Delegate* delegate) override;
31 void Show(const std::vector<PermissionRequest*>& requests, 27 void Show(const std::vector<PermissionRequest*>& requests,
32 const std::vector<bool>& accept_state) override; 28 const std::vector<bool>& accept_state) override;
33 bool CanAcceptRequestUpdate() override; 29 bool CanAcceptRequestUpdate() override;
30 bool HidesAutomatically() override;
34 void Hide() override; 31 void Hide() override;
35 bool IsVisible() override; 32 bool IsVisible() override;
36 void UpdateAnchorPosition() override; 33 void UpdateAnchorPosition() override;
37 gfx::NativeWindow GetNativeWindow() override; 34 gfx::NativeWindow GetNativeWindow() override;
38 35
39 void Closing(); 36 void Closing();
40 void ToggleAccept(int index, bool value); 37 void ToggleAccept(int index, bool value);
41 void Accept(); 38 void Accept();
42 void Deny(); 39 void Deny();
43 40
44 size_t permission_count() const { return requests_.size(); } 41 size_t permission_count() const { return requests_.size(); }
45 ContentSettingsType GetContentSettingType(size_t position) const; 42 ContentSettingsType GetContentSettingType(size_t position) const;
46 int GetIconIdForPermission(size_t position) const; 43 int GetIconIdForPermission(size_t position) const;
47 base::string16 GetMessageTextFragment(size_t position) const; 44 base::string16 GetMessageTextFragment(size_t position) const;
48 45
49 private: 46 private:
50 // PermissionPromptAndroid is owned by PermissionRequestManager, so it should 47 // PermissionPromptAndroid is owned by PermissionRequestManager, so it should
51 // be safe to hold a raw WebContents pointer here because this class is 48 // be safe to hold a raw WebContents pointer here because this class is
52 // destroyed before the WebContents. 49 // destroyed before the WebContents.
53 content::WebContents* web_contents_; 50 content::WebContents* web_contents_;
54 // |delegate_| is the PermissionRequestManager, which owns this object. 51 // |delegate_| is the PermissionRequestManager, which owns this object.
55 Delegate* delegate_; 52 Delegate* delegate_;
56 // |infobar_| is owned by the InfoBarService; we keep a pointer here so we can
57 // ask the service to remove the infobar after it is added.
58 infobars::InfoBar* infobar_;
59 // The current request being displayed (if any). 53 // The current request being displayed (if any).
60 std::vector<PermissionRequest*> requests_; 54 std::vector<PermissionRequest*> requests_;
61 55
62 DISALLOW_COPY_AND_ASSIGN(PermissionPromptAndroid); 56 DISALLOW_COPY_AND_ASSIGN(PermissionPromptAndroid);
63 }; 57 };
64 58
65 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_ 59 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_PROMPT_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698