Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2755583003: color: Remove flags for true color rendering (Closed)

Created:
2 years, 2 months ago by ccameron
Modified:
2 years, 2 months ago
Reviewers:
esprehn
CC:
achuith+watch_chromium.org, ajuma+watch_chromium.org, alemate+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jam, jbauman+watch_chromium.org, jbroman, Justin Novosad, kalyank, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, oshima+watch_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Remove flags for true color rendering This is having too many complicated interactions with color correct rendering and rasterization, and can be re-added (probably in a slightly different form) once color correct render is on by default. R=esprehn TBR=achuith (for chrome/browser/chromeos/login) BUG=667433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2755583003 Cr-Commit-Position: refs/heads/master@{#456969} Committed: https://chromium.googlesource.com/chromium/src/+/b59418b55e5b899b7e11ad34ebd2df269baf5708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M cc/base/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
ccameron
esprehn, can you take a quick look to make sure I didn't miss anything here?
2 years, 2 months ago (2017-03-15 01:05:37 UTC) #6
esprehn
This lgtm to me.
2 years, 2 months ago (2017-03-15 01:10:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755583003/1
2 years, 2 months ago (2017-03-15 02:11:36 UTC) #12
commit-bot: I haz the power
2 years, 2 months ago (2017-03-15 02:53:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b59418b55e5b899b7e11ad34ebd2...

Powered by Google App Engine
This is Rietveld 408576698