Add ContentSuggestion for ReadingList

Add ContentSuggestion for ReadingList

This CL allows the ContentSuggestionsUpdater to display the
ReadingListContentSuggestions.

BUG=702241, 706296
Review-Url: https://codereview.chromium.org/2755383002
Cr-Commit-Position: refs/heads/master@{#460731}
Committed: https://chromium.googlesource.com/chromium/src/+/24939285bd24532cc0c2ffca609c5e80073cd9f4

[gambard, 2017-03-29 07:25:58]

Description was changed from

==========
Prepare ContentSuggestions for more sections

This CL allows the ContentSuggestionsUpdater to treat more kind of suggestions.

BUG=702241
==========

to

==========
Add ContentSuggestion for ReadingList

This CL allows the ContentSuggestionsUpdater to display the
ReadingListContentSuggestions.

BUG=702241, 706296
==========

[gambard, 2017-03-29 12:55:44]

gambard@chromium.org changed reviewers:
+ jif@chromium.org

[gambard, 2017-03-29 12:55:45]

PTAL.

[jif, 2017-03-30 08:54:35]

lgtm

https://codereview.chromium.org/2755383002/diff/80001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
(right):

https://codereview.chromium.org/2755383002/diff/80001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm:240:
// Opens the Reading List entry display by |item|. |item| must be a
nit:
s/display/displayed/ ?
s/display by/associated with/ ?

[gambard, 2017-03-30 09:02:09]

Thanks!

https://codereview.chromium.org/2755383002/diff/80001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
(right):

https://codereview.chromium.org/2755383002/diff/80001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm:240:
// Opens the Reading List entry display by |item|. |item| must be a
On 2017/03/30 08:54:35, jif wrote:
> nit:
> s/display/displayed/ ?
> s/display by/associated with/ ?

Done.

[gambard, 2017-03-30 10:58:08]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-03-30 10:58:08]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2755383002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-30 10:58:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 11:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 11:27:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gambard, 2017-03-30 11:28:55]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-03-30 11:29:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 12:12:16]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490873335193320,
"parent_rev": "765cc1c8a14a1c6dfdfdb4ffb2e9b68d4766944a", "commit_rev":
"24939285bd24532cc0c2ffca609c5e80073cd9f4"}

[commit-bot: I haz the power, 2017-03-30 12:13:00]

Description was changed from

==========
Add ContentSuggestion for ReadingList

This CL allows the ContentSuggestionsUpdater to display the
ReadingListContentSuggestions.

BUG=702241, 706296
==========

to

==========
Add ContentSuggestion for ReadingList

This CL allows the ContentSuggestionsUpdater to display the
ReadingListContentSuggestions.

BUG=702241, 706296

Review-Url: https://codereview.chromium.org/2755383002
Cr-Commit-Position: refs/heads/master@{#460731}
Committed:
https://chromium.googlesource.com/chromium/src/+/24939285bd24532cc0c2ffca609c...
==========

[commit-bot: I haz the power, 2017-03-30 12:13:01]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/24939285bd24532cc0c2ffca609c...