Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2790543002: Register the ReadingListProvider (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
Olivier
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, ntp-dev+reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Register the ReadingListProvider This CL register the ReadingListProvider in the ContentSuggestionsService, allowing the ReadingListEntries to be displayed. BUG=702241 Review-Url: https://codereview.chromium.org/2790543002 Cr-Commit-Position: refs/heads/master@{#461085} Committed: https://chromium.googlesource.com/chromium/src/+/42692e1c75507ae5a4f9f55c357c5fda2b0a89ab

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ios/chrome/browser/ntp_snippets/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc View 1 5 chunks +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2755383002 Patch 120001

Messages

Total messages: 10 (4 generated)
gambard
PTAL.
3 years, 8 months ago (2017-03-30 09:52:42 UTC) #2
Olivier
https://codereview.chromium.org/2790543002/diff/1/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc File ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc (right): https://codereview.chromium.org/2790543002/diff/1/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc#newcode111 ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc:111: DependsOn(ios::SigninManagerFactory::GetInstance()); Please depend on ReadingList.
3 years, 8 months ago (2017-03-30 11:04:39 UTC) #3
gambard
Thanks, PTAL. https://codereview.chromium.org/2790543002/diff/1/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc File ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc (right): https://codereview.chromium.org/2790543002/diff/1/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc#newcode111 ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc:111: DependsOn(ios::SigninManagerFactory::GetInstance()); On 2017/03/30 11:04:39, Olivier Robin wrote: ...
3 years, 8 months ago (2017-03-30 11:07:58 UTC) #4
Olivier
lgtm
3 years, 8 months ago (2017-03-31 07:51:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790543002/20001
3 years, 8 months ago (2017-03-31 08:21:06 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 09:16:15 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/42692e1c75507ae5a4f9f55c357c...

Powered by Google App Engine
This is Rietveld 408576698