Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2755323002: [Bindings] Emit less code per member in generated dictionary ToV8. (Closed)

Created:
1 year, 1 month ago by jbroman
Modified:
1 year, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Bindings] Emit less code per member in generated dictionary ToV8. Currently, we emit two invocations of CreateDataProperty for members that are defaulted or nullable. Since the invocation and handling is identical in all cases where we store a value, we can emit the code to do so just once. This reduces Android APK size by 16 KiB. The difference in specific symbols is can be fairly dramatic, with code size of conversion methods reduced by up to 35%. Review-Url: https://codereview.chromium.org/2755323002 Cr-Commit-Position: refs/heads/master@{#457998} Committed: https://chromium.googlesource.com/chromium/src/+/0ff10ccfef86c660f344077896fb93ebea341ec8

Patch Set 1 #

Messages

Total messages: 16 (12 generated)
jbroman
1 year, 1 month ago (2017-03-19 05:02:41 UTC) #10
haraken
LGTM
1 year, 1 month ago (2017-03-19 05:59:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755323002/1
1 year, 1 month ago (2017-03-19 18:11:04 UTC) #13
commit-bot: I haz the power
1 year, 1 month ago (2017-03-19 18:16:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ff10ccfef86c660f344077896fb...

Powered by Google App Engine
This is Rietveld 408576698