[Bindings] Emit less code per member in generated dictionary ToV8.

[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. The difference in specific
symbols is can be fairly dramatic, with code size of conversion methods
reduced by up to 35%.

Review-Url: https://codereview.chromium.org/2755323002
Cr-Commit-Position: refs/heads/master@{#457998}
Committed: https://chromium.googlesource.com/chromium/src/+/0ff10ccfef86c660f344077896fb93ebea341ec8

[jbroman, 2017-03-18 22:54:35]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 22:54:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-03-18 23:18:49]

Description was changed from

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB.
==========

to

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. (The difference in specific
symbols is can be fairly dramatic, with code size reduced by up to 35%.)
==========

[jbroman, 2017-03-18 23:20:15]

Description was changed from

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. (The difference in specific
symbols is can be fairly dramatic, with code size reduced by up to 35%.)
==========

to

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. The difference in specific
symbols is can be fairly dramatic, with code size reduced by up to 35%.
For example, toV8MediaTrackSupportedConstraints shrinks from 3.8k to 2.5k.
==========

[jbroman, 2017-03-18 23:20:39]

Description was changed from

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. The difference in specific
symbols is can be fairly dramatic, with code size reduced by up to 35%.
For example, toV8MediaTrackSupportedConstraints shrinks from 3.8k to 2.5k.
==========

to

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. The difference in specific
symbols is can be fairly dramatic, with code size reduced by up to 35%.
==========

[jbroman, 2017-03-18 23:49:39]

Description was changed from

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. The difference in specific
symbols is can be fairly dramatic, with code size reduced by up to 35%.
==========

to

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. The difference in specific
symbols is can be fairly dramatic, with code size of conversion methods
reduced by up to 35%.
==========

[commit-bot: I haz the power, 2017-03-19 00:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 00:14:58]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-03-19 05:02:40]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-03-19 05:59:40]

LGTM

[jbroman, 2017-03-19 18:10:53]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-03-19 18:11:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-19 18:15:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489947053696890, "parent_rev":
"8ad9fcbb9107bf9c945c8eaa6a0124124a4956f7", "commit_rev":
"0ff10ccfef86c660f344077896fb93ebea341ec8"}

[commit-bot: I haz the power, 2017-03-19 18:16:31]

Description was changed from

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. The difference in specific
symbols is can be fairly dramatic, with code size of conversion methods
reduced by up to 35%.
==========

to

==========
[Bindings] Emit less code per member in generated dictionary ToV8.

Currently, we emit two invocations of CreateDataProperty for members
that are defaulted or nullable. Since the invocation and handling is
identical in all cases where we store a value, we can emit the code to
do so just once.

This reduces Android APK size by 16 KiB. The difference in specific
symbols is can be fairly dramatic, with code size of conversion methods
reduced by up to 35%.

Review-Url: https://codereview.chromium.org/2755323002
Cr-Commit-Position: refs/heads/master@{#457998}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ff10ccfef86c660f344077896fb...
==========

[commit-bot: I haz the power, 2017-03-19 18:16:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ff10ccfef86c660f344077896fb...