Fix issue 701381.

Expand case-insensitive matching of Document.createEvent()

If a specified interface name is an ASCII case insensitive match for any of the
strings in the first in the table in [1], then the set constructor to the
interface in the second column on the same row as the matching string.

In make_event_factory.py file. create_event_legacy_whitelist is renamed to
create_event_measure_whitelist. All events on the create_event_measure_whitelist
are matched case-insensitively in createEvent and are measured using UseCounter

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=603614
Review-Url: https://codereview.chromium.org/2755313002
Cr-Commit-Position: refs/heads/master@{#461236}
Committed: https://chromium.googlesource.com/chromium/src/+/c2cffeaaa19ba03e23cbce4291be97a85e14dd78

[Huy Duong, 2017-03-18 09:27:46]

huy.duongdinh@gmail.com changed reviewers:
+ tkent@chromium.org

[Huy Duong, 2017-03-18 09:27:47]

Hi

This is my fix for issue 701381 
I am new to Chromium development. This is my fist contribution to Chromium. So
please double check to make sure that everything is up to your standards.
Thanks

Best Regards 
Duong Dinh Huy

[tkent, 2017-03-18 10:31:54]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 10:31:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 11:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 11:45:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-03-20 22:46:15]

tkent@chromium.org changed reviewers:
+ foolip@chromium.org

[tkent, 2017-03-20 22:51:07]

+foolip@

Huy,
Please update the test result of
external/wpt/dom/nodes/Document-createEvent.html

CL description:
> Fix issue 701381.

The first line of the CL description should explain the behavior change briefly.
 e.g. "Expand case-insensitive matching of Document.createEvent()"

> create_event_whitelist does not mesure event using UseCounter so I decided
> create new whilelist (events are matched case-insensitively and are mesured
using UseCounter)

mesure -> measure
mesured -> measured

https://codereview.chromium.org/2755313002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (right):

https://codereview.chromium.org/2755313002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_event_factory.py:67: # in
createEvent and are mesured using UseCounter.
mesured -> measured

[foolip, 2017-03-21 02:41:15]

https://codereview.chromium.org/2755313002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (right):

https://codereview.chromium.org/2755313002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_event_factory.py:68: def
create_event_whitelist_use_counter(name):
I don't think that a new list should be needed. I would rather suggest that
create_event_legacy_whitelist is renamed to create_event_measure_whitelist, as
the list of things that have use counters. But change it to match insensitively
just like the above list. Retaining a small number of strings that are still
matched case-sensitively isn't useful I think. (Originally I worried about usage
increasing if we did this, and removal becoming harder, but that seems fairly
implausible.)

[Huy Duong, 2017-03-22 18:54:02]

On 2017/03/20 22:51:07, tkent wrote:
> +foolip@
> 
> Huy,
> Please update the test result of
> external/wpt/dom/nodes/Document-createEvent.html
> 
> CL description:
> > Fix issue 701381.
> 
> The first line of the CL description should explain the behavior change
briefly.
>  e.g. "Expand case-insensitive matching of Document.createEvent()"
> 
> > create_event_whitelist does not mesure event using UseCounter so I decided
> > create new whilelist (events are matched case-insensitively and are mesured
> using UseCounter)
> 
> mesure -> measure
> mesured -> measured
> 
>
https://codereview.chromium.org/2755313002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/build/scripts/make_event_factory.py (right):
> 
>
https://codereview.chromium.org/2755313002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/build/scripts/make_event_factory.py:67: # in
> createEvent and are mesured using UseCounter.
> mesured -> measured

Hi
I updated the test result of external/wpt/dom/nodes/Document-createEvent.html
Please check
Thanks

[Huy Duong, 2017-03-22 19:04:08]

Description was changed from

==========
Fix issue 701381.
If inteface is an ASCII case insensitive match for any of the strings in the
first in the table in [1], then the set constructor to the interface in the
second column on the same row as the matching string.

Change the whitelist in make_event_factory.py. I intended move events in
create_event_legacy_whitelist to create_event_whitelist but
create_event_whitelist does not mesure event using UseCounter so I decided
create new whilelist (events are matched case-insensitively and are mesured
using UseCounter)

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=701381
==========

to

==========
Expand case-insensitive matching of Document.createEvent()

If inteface is an ASCII case insensitive match for any of the strings in the
first in the table in [1], then the set constructor to the interface in the
second column on the same row as the matching string.

In make_event_factory.py file. create_event_legacy_whitelist is renamed to
create_event_measure_whitelist. All events on the create_event_measure_whitelist
are matched case-insensitively in createEvent and are measured using UseCounter

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=701381
==========

[Huy Duong, 2017-03-23 15:31:08]

Description was changed from

==========
Expand case-insensitive matching of Document.createEvent()

If inteface is an ASCII case insensitive match for any of the strings in the
first in the table in [1], then the set constructor to the interface in the
second column on the same row as the matching string.

In make_event_factory.py file. create_event_legacy_whitelist is renamed to
create_event_measure_whitelist. All events on the create_event_measure_whitelist
are matched case-insensitively in createEvent and are measured using UseCounter

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=701381
==========

to

==========
Expand case-insensitive matching of Document.createEvent()

If inteface is an ASCII case insensitive match for any of the strings in the
first in the table in [1], then the set constructor to the interface in the
second column on the same row as the matching string.

In make_event_factory.py file. create_event_legacy_whitelist is renamed to
create_event_measure_whitelist. All events on the create_event_measure_whitelist
are matched case-insensitively in createEvent and are measured using UseCounter

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=603614
==========

[tkent, 2017-03-29 00:13:32]

Description was changed from

==========
Expand case-insensitive matching of Document.createEvent()

If inteface is an ASCII case insensitive match for any of the strings in the
first in the table in [1], then the set constructor to the interface in the
second column on the same row as the matching string.

In make_event_factory.py file. create_event_legacy_whitelist is renamed to
create_event_measure_whitelist. All events on the create_event_measure_whitelist
are matched case-insensitively in createEvent and are measured using UseCounter

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=603614
==========

to

==========
Expand case-insensitive matching of Document.createEvent()

If a specified interface name is an ASCII case insensitive match for any of the
strings in the first in the table in [1], then the set constructor to the
interface in the second column on the same row as the matching string.

In make_event_factory.py file. create_event_legacy_whitelist is renamed to
create_event_measure_whitelist. All events on the create_event_measure_whitelist
are matched case-insensitively in createEvent and are measured using UseCounter

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=603614
==========

[tkent, 2017-03-29 00:13:43]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-29 00:13:43]

lgtm

[commit-bot: I haz the power, 2017-03-29 00:14:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 00:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 00:18:13]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-03-29 00:20:03]

Huy.DuongDinh, would you rebase and re-upload the patch please?

[Huy Duong, 2017-03-29 20:27:29]

On 2017/03/29 00:20:03, tkent wrote:
> Huy.DuongDinh, would you rebase and re-upload the patch please?

Done.
Please check it.
Thanks

[tkent, 2017-03-29 21:15:43]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-29 21:15:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2755313002/#ps40001
(title: "Rebase and reupload the patch")

[commit-bot: I haz the power, 2017-03-29 21:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:07:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-03-29 23:13:35]

https://codereview.chromium.org/2755313002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt
(right):

https://codereview.chromium.org/2755313002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt:3:
PASS AnimationEvent should be an alias for AnimationEvent.
Looks you edited the file manually? This line shouldn't be changed.

You can update -expected.txt by a command like:
  third_party/WebKit/Tools/Scripts/run-webkit-tests ...
external/wpt/dom/nodes/DOcument-createEvent.html --reset

[Huy Duong, 2017-03-30 13:53:14]

On 2017/03/29 23:13:35, tkent wrote:
>
https://codereview.chromium.org/2755313002/diff/40001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2755313002/diff/40001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt:3:
> PASS AnimationEvent should be an alias for AnimationEvent.
> Looks you edited the file manually? This line shouldn't be changed.
> 
> You can update -expected.txt by a command like:
>   third_party/WebKit/Tools/Scripts/run-webkit-tests ...
> external/wpt/dom/nodes/DOcument-createEvent.html --reset

Hi
Sorry for being annoying 
The Document-createEvent-expected.text which i committed I got by running
DOcument-createEvent.html directly.
Currently I can not run script run-webkit-tests. I tried and got the following
error:

Found 1 test; running 1, skipping 0.
Unable to find test driver
    at /Users/dinhhuy258/Desktop/chromium/src/out/Release/Content
Shell.app/Contents/MacOS/Content Shell
image_diff was not found at
/Users/dinhhuy258/Desktop/chromium/src/out/Release/image_diff
For complete Mac build requirements, please see:

I also can not see Content Shell.app and image_diff in out/Release folder
Did I make a mistake when build the project?
This is my args 

cc_wrapper = "ccache"
is_debug = false
is_component_build = true
symbol_level = 0
enable_nacl = false
remove_webcore_debug_symbols = true

Sorry for my ignorance.

[tkent, 2017-03-30 14:10:32]

> Currently I can not run script run-webkit-tests. I tried and got the following
error:
> 
> Found 1 test; running 1, skipping 0.
> Unable to find test driver
>     at /Users/dinhhuy258/Desktop/chromium/src/out/Release/Content
Shell.app/Contents/MacOS/Content Shell
> image_diff was not found at
/Users/dinhhuy258/Desktop/chromium/src/out/Release/image_diff

You need to build "blink_tests" target.  e.g.
 % ninja -C out/Release blink_tests

Also, the following zip contains a test result produced by a binary with this
CL.
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
You may copy Document-createEvent-actual.txt in it to
LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt

[Huy Duong, 2017-03-30 17:14:11]

On 2017/03/30 14:10:32, tkent wrote:
> > Currently I can not run script run-webkit-tests. I tried and got the
following
> error:
> > 
> > Found 1 test; running 1, skipping 0.
> > Unable to find test driver
> >     at /Users/dinhhuy258/Desktop/chromium/src/out/Release/Content
> Shell.app/Contents/MacOS/Content Shell
> > image_diff was not found at
> /Users/dinhhuy258/Desktop/chromium/src/out/Release/image_diff
> 
> You need to build "blink_tests" target.  e.g.
>  % ninja -C out/Release blink_tests
> 
> Also, the following zip contains a test result produced by a binary with this
> CL.
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
> You may copy Document-createEvent-actual.txt in it to
> LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt

Thanks for your support...
Please check it again.
Sorry for wasting your time

[tkent, 2017-03-30 20:55:12]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 20:56:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:43:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2017-03-30 22:54:50]

On 2017/03/30 at 17:14:11, Huy.DuongDinh wrote:
> Please check it again.
> Sorry for wasting your time

Looks you still uploaded a wrong -expected.txt.

Diff of the latest try run:
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

Test results on a try bot:
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

[Huy Duong, 2017-03-31 15:49:03]

On 2017/03/30 22:54:50, tkent wrote:
> On 2017/03/30 at 17:14:11, Huy.DuongDinh wrote:
> > Please check it again.
> > Sorry for wasting your time
> 
> Looks you still uploaded a wrong -expected.txt.
> 
> Diff of the latest try run:
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
> 
> Test results on a try bot:
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

Yes I uploaded a wrong-expected, 
I updated the correct file
Thanks for your patience and helping me in this PR.
I will be more be careful next time.
Thank you and have a nice weekend.

[tkent, 2017-03-31 15:56:12]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 15:56:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 19:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 19:53:12]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-03-31 21:24:37]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-31 21:24:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2755313002/#ps80001
(title: "Update the test result")

[commit-bot: I haz the power, 2017-03-31 21:25:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 21:35:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490995477594010,
"parent_rev": "3f4231f979090ad23fd89622b3b36ed564650645", "commit_rev":
"c2cffeaaa19ba03e23cbce4291be97a85e14dd78"}

[commit-bot: I haz the power, 2017-03-31 21:36:08]

Description was changed from

==========
Expand case-insensitive matching of Document.createEvent()

If a specified interface name is an ASCII case insensitive match for any of the
strings in the first in the table in [1], then the set constructor to the
interface in the second column on the same row as the matching string.

In make_event_factory.py file. create_event_legacy_whitelist is renamed to
create_event_measure_whitelist. All events on the create_event_measure_whitelist
are matched case-insensitively in createEvent and are measured using UseCounter

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=603614
==========

to

==========
Expand case-insensitive matching of Document.createEvent()

If a specified interface name is an ASCII case insensitive match for any of the
strings in the first in the table in [1], then the set constructor to the
interface in the second column on the same row as the matching string.

In make_event_factory.py file. create_event_legacy_whitelist is renamed to
create_event_measure_whitelist. All events on the create_event_measure_whitelist
are matched case-insensitively in createEvent and are measured using UseCounter

The patch ensures that the test in [2] has less fail

[1]: https://dom.spec.whatwg.org/#dom-document-createevent
[2]: http://w3c-test.org/dom/nodes/Document-createEvent.html

BUG=603614

Review-Url: https://codereview.chromium.org/2755313002
Cr-Commit-Position: refs/heads/master@{#461236}
Committed:
https://chromium.googlesource.com/chromium/src/+/c2cffeaaa19ba03e23cbce4291be...
==========

[commit-bot: I haz the power, 2017-03-31 21:36:10]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c2cffeaaa19ba03e23cbce4291be...