Fix issue 701381.

third_party/WebKit/Source/build/scripts/make_event_factory.py

 #!/usr/bin/env python
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 45 matching lines @@
             or name == 'Event'
             or name == 'Events'
             or name.startswith('UIEvent')
             or name.startswith('CustomEvent')
             or name == 'KeyboardEvent'
             or name == 'MessageEvent'
             or name.startswith('MouseEvent')
             or name == 'TouchEvent')
 
 
-# All events on the following whitelist are matched case-sensitively
-# in createEvent and are measured using UseCounter.
-#
-# TODO(foolip): All events on this list should either be added to the spec and
-# moved to the above whitelist (causing them to be matched case-insensitively)
-# or be deprecated/removed. https://crbug.com/569690
-def create_event_legacy_whitelist(name):
+# All events on the following whitelist are matched case-insensitively
+# in createEvent and are mesured using UseCounter.

[tkent, 2017/03/20 22:51:07]

mesured -> measured

+def create_event_whitelist_use_counter(name):

[foolip, 2017/03/21 02:41:14]

I don't think that a new list should be needed. I would rather suggest that
create_event_legacy_whitelist is renamed to create_event_measure_whitelist, as
the list of things that have use counters. But change it to match insensitively
just like the above list. Retaining a small number of strings that are still
matched case-sensitively isn't useful I think. (Originally I worried about usage
increasing if we did this, and removal becoming harder, but that seems fairly
implausible.)

     return (name == 'AnimationEvent'
             or name == 'BeforeUnloadEvent'
             or name == 'CloseEvent'
             or name == 'CompositionEvent'
             or name == 'DeviceMotionEvent'
             or name == 'DeviceOrientationEvent'
             or name == 'DragEvent'
             or name == 'ErrorEvent'
             or name == 'FocusEvent'
             or name == 'HashChangeEvent'
             or name == 'IDBVersionChangeEvent'
-            or name == 'KeyboardEvents'
-            or name == 'MutationEvent'
-            or name == 'MutationEvents'
             or name == 'PageTransitionEvent'
             or name == 'PopStateEvent'
             or name == 'ProgressEvent'
             or name == 'StorageEvent'
             or name == 'SVGEvents'
             or name == 'TextEvent'
             or name == 'TrackEvent'
             or name == 'TransitionEvent'
             or name == 'WebGLContextEvent'
+            or name == 'WheelEvent')
+
+
+# All events on the following whitelist are matched case-sensitively
+# in createEvent and are measured using UseCounter.
+#
+# TODO(foolip): All events on this list should either be added to the spec and
+# moved to the above whitelist (causing them to be matched case-insensitively)
+# or be deprecated/removed. https://crbug.com/569690
+def create_event_legacy_whitelist(name):
+    return (name == 'KeyboardEvents'
+            or name == 'MutationEvent'
+            or name == 'MutationEvents'
             or name == 'WebKitAnimationEvent'
-            or name == 'WebKitTransitionEvent'
-            or name == 'WheelEvent')
+            or name == 'WebKitTransitionEvent')
 
 
 def measure_name(name):
     return 'DocumentCreateEvent' + name
 
 
 class EventFactoryWriter(json5_generator.Writer):
     default_parameters = {
         'ImplementedAs': None,
         'RuntimeEnabled': None,
     }
     default_metadata = {
         'export': '',
         'namespace': '',
         'suffix': '',
     }
     filters = {
         'cpp_name': name_utilities.cpp_name,
         'lower_first': name_utilities.lower_first,
         'script_name': name_utilities.script_name,
         'create_event_whitelist': create_event_whitelist,
         'create_event_legacy_whitelist': create_event_legacy_whitelist,
+        'create_event_whitelist_use_counter': create_event_whitelist_use_counter,
         'measure_name': measure_name,
     }
 
     def __init__(self, json5_file_path):
         super(EventFactoryWriter, self).__init__(json5_file_path)
         self.namespace = self.json5_file.metadata['namespace'].strip('"')
         self.suffix = self.json5_file.metadata['suffix'].strip('"')
         self._outputs = {(self.namespace + self.suffix + "Headers.h"): self.generate_headers_header,
                          (self.namespace + self.suffix + ".cpp"): self.generate_implementation,
                         }
@@ skipping 46 matching lines @@
     def generate_implementation(self):
         return {
             'namespace': self.namespace,
             'suffix': self.suffix,
             'events': self.json5_file.name_dictionaries,
         }
 
 
 if __name__ == "__main__":
     json5_generator.Maker(EventFactoryWriter).main()