Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2755143002: Revert of Avoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isSc… (Closed)

Created:
8 months ago by esprehn
Modified:
8 months ago
Reviewers:
sof, dglazkov, jbroman
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isScriptForbid… (patchset #2 id:20001 of https://codereview.chromium.org/2709763003/ ) Reason for revert: meh. Original issue's description: > Avoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isScriptForbidden(). > > Usually when s_scriptForbiddenCount is true we're about to crash, so check that > first then check which thread it is. This means a background thread will read > the potentially racy value of the counter, but it'll always return false when > it checks isMainThread() next. > > Review-Url: https://codereview.chromium.org/2709763003 > Cr-Commit-Position: refs/heads/master@{#456284} > Committed: https://chromium.googlesource.com/chromium/src/+/3b4b07ced6315a25960ca5a51dd1b7ba88de53db TBR=dglazkov@chromium.org,jbroman@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2755143002 Cr-Commit-Position: refs/heads/master@{#458085} Committed: https://chromium.googlesource.com/chromium/src/+/36b4ac1bd5e75a1d3a37cfb7188c50cd754a3ca7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/Source/platform/ScriptForbiddenScope.h View 1 chunk +1 line, -5 lines 0 comments Download
Trybot results:  win_chromium_rel_ng   mac_chromium_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   android_compile_dbg   linux_chromium_rel_ng   mac_chromium_compile_dbg_ng   linux_android_rel_ng   android_n5x_swarming_rel   android_clang_dbg_recipe   linux_chromium_asan_rel_ng   linux_chromium_tsan_rel_ng   chromium_presubmit   ios-simulator   chromeos_daisy_chromium_compile_only_ng   ios-device-xcode-clang   ios-device   android_arm64_dbg_recipe   cast_shell_android   android_cronet   linux_chromium_chromeos_ozone_rel_ng   ios-simulator-xcode-clang   cast_shell_linux   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   linux_chromium_tsan_rel_ng   win_clang   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   cast_shell_linux   linux_chromium_chromeos_rel_ng   linux_android_rel_ng   win_chromium_rel_ng   linux_chromium_asan_rel_ng   ios-device   ios-simulator   linux_chromium_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   ios-device-xcode-clang   mac_chromium_rel_ng   chromium_presubmit   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   android_n5x_swarming_rel   android_compile_dbg   cast_shell_android   android_arm64_dbg_recipe   android_cronet   android_clang_dbg_recipe 

Messages

Total messages: 9 (5 generated)
esprehn
Created Revert of Avoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isScriptForbid…
8 months ago (2017-03-17 15:29:33 UTC) #2
sof
if needed, lgtm (acquireLoad(..) not palatable? )
8 months ago (2017-03-17 18:44:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755143002/1
8 months ago (2017-03-20 15:05:19 UTC) #6
commit-bot: I haz the power
8 months ago (2017-03-20 16:37:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/36b4ac1bd5e75a1d3a37cfb7188c...

Powered by Google App Engine
This is Rietveld efc10ee0f