|
|
DescriptionAvoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isScriptForbidden().
Usually when s_scriptForbiddenCount is true we're about to crash, so check that
first then check which thread it is. This means a background thread will read
the potentially racy value of the counter, but it'll always return false when
it checks isMainThread() next.
Review-Url: https://codereview.chromium.org/2709763003
Cr-Commit-Position: refs/heads/master@{#456284}
Committed: https://chromium.googlesource.com/chromium/src/+/3b4b07ced6315a25960ca5a51dd1b7ba88de53db
Patch Set 1 #Patch Set 2 : english. #Messages
Total messages: 27 (15 generated)
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Avoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isScriptForbidden(). BUG= ========== to ========== Avoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isScriptForbidden(). Usually when s_scriptForbiddenCount is true we're about to crash, so check that first then check which thread it is. This means a background thread will read the potentially racy value of the counter, but it'll always return false when it checks isMainThread() next. ==========
esprehn@chromium.org changed reviewers: + dglazkov@chromium.org, jbroman@chromium.org
lgtm
The CQ bit was unchecked by esprehn@chromium.org
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489196776596540, "parent_rev": "a54a48cb6f59fe24dd4a4e566d42c9f059e9e242", "commit_rev": "3b4b07ced6315a25960ca5a51dd1b7ba88de53db"}
Message was sent while issue was closed.
Description was changed from ========== Avoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isScriptForbidden(). Usually when s_scriptForbiddenCount is true we're about to crash, so check that first then check which thread it is. This means a background thread will read the potentially racy value of the counter, but it'll always return false when it checks isMainThread() next. ========== to ========== Avoid calling isMainThread() in the common cases when checking ScriptForbiddenScope::isScriptForbidden(). Usually when s_scriptForbiddenCount is true we're about to crash, so check that first then check which thread it is. This means a background thread will read the potentially racy value of the counter, but it'll always return false when it checks isMainThread() next. Review-Url: https://codereview.chromium.org/2709763003 Cr-Commit-Position: refs/heads/master@{#456284} Committed: https://chromium.googlesource.com/chromium/src/+/3b4b07ced6315a25960ca5a51dd1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3b4b07ced6315a25960ca5a51dd1...
Message was sent while issue was closed.
sigbjornf@opera.com changed reviewers: + sigbjornf@opera.com
Message was sent while issue was closed.
Could the read be made atomic to avoid (e.g.) crbug.com/700720 'noise' ?
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2755143002/ by esprehn@chromium.org. The reason for reverting is: meh.. |