Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2755063002: Revert of Add a CHECK for null stuff in CompactPendingRules (Closed)

Created:
3 years, 9 months ago by meade_UTC10
Modified:
3 years, 9 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a CHECK for null stuff in CompactPendingRules (patchset #2 id:20001 of https://codereview.chromium.org/2740013002/ ) Reason for revert: Reverting as I finish up my investigation. Original issue's description: > Add a CHECK for null stuff in CompactPendingRules > > This should be impossible, but we'd like to try it in canary > to try and figure out what's going on in the linked bug. > > This should be reverted by 17 March. > > BUG=694520 > > Review-Url: https://codereview.chromium.org/2740013002 > Cr-Commit-Position: refs/heads/master@{#455697} > Committed: https://chromium.googlesource.com/chromium/src/+/f84d6e755704745c233c23d7e652354ce7de227a TBR=esprehn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=694520 Review-Url: https://codereview.chromium.org/2755063002 Cr-Commit-Position: refs/heads/master@{#457691} Committed: https://chromium.googlesource.com/chromium/src/+/0bc5ffca0d9756f49fba26e03fcdf8c3d58877c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M third_party/WebKit/Source/core/css/RuleSet.cpp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
meade_UTC10
Created Revert of Add a CHECK for null stuff in CompactPendingRules
3 years, 9 months ago (2017-03-17 03:24:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755063002/1
3 years, 9 months ago (2017-03-17 03:24:48 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 05:13:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0bc5ffca0d9756f49fba26e03fcd...

Powered by Google App Engine
This is Rietveld 408576698