Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2740013002: Add a CHECK for null stuff in CompactPendingRules (Closed)

Created:
3 years, 9 months ago by meade_UTC10
Modified:
3 years, 9 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a CHECK for null stuff in CompactPendingRules This should be impossible, but we'd like to try it in canary to try and figure out what's going on in the linked bug. This should be reverted by 17 March. BUG=694520 Review-Url: https://codereview.chromium.org/2740013002 Cr-Commit-Position: refs/heads/master@{#455697} Committed: https://chromium.googlesource.com/chromium/src/+/f84d6e755704745c233c23d7e652354ce7de227a

Patch Set 1 #

Patch Set 2 : Add one more check + TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
meade_UTC10
3 years, 9 months ago (2017-03-09 07:07:58 UTC) #3
esprehn
lgtm
3 years, 9 months ago (2017-03-09 07:08:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740013002/20001
3 years, 9 months ago (2017-03-09 07:09:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f84d6e755704745c233c23d7e652354ce7de227a
3 years, 9 months ago (2017-03-09 08:31:01 UTC) #10
meade_UTC10
3 years, 9 months ago (2017-03-17 03:24:15 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2755063002/ by meade@chromium.org.

The reason for reverting is: Reverting as I finish up my investigation..

Powered by Google App Engine
This is Rietveld 408576698