Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 2755053002: Generate the storage of pseudoBits and styleType in ComputedStyleBase. (Closed)

Created:
1 year, 2 months ago by shend
Modified:
1 year, 2 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate the storage of pseudoBits and styleType in ComputedStyleBase. In ComputedStyle, pseudoBits and styleType are two data members used for storing psuedoelement styles. Their interface is difficult to generate because: 1) They share the same enum, but not all enum values are valid for styleType. 2) pseudoBits is a bit set, which we can't generate yet. This patch uses the 'storage_only' template to move the storage of both fields to ComputedStyleBase first, and keep the interfaces handwritten. This is prework for either generating those fields properly or removing pseudo style information from ComputedStyle entirely. Diff of generated files: https://gist.github.com/darrnshn/1044b3bd2822c62072ab6f0e22f43104/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2755053002 Cr-Commit-Position: refs/heads/master@{#459290} Committed: https://chromium.googlesource.com/chromium/src/+/6b815d45f10ca1b8fb208647f2a0576bdf31e006

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fix default values #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Messages

Total messages: 38 (33 generated)
shend
Hi Alan, PTAL :)
1 year, 2 months ago (2017-03-17 00:43:56 UTC) #2
alancutter (OOO until 2018)
Please upload the generated diff.
1 year, 2 months ago (2017-03-20 05:14:13 UTC) #3
alancutter (OOO until 2018)
lgtm. I think the "// Not generated" could be more explicit about what's not generated ...
1 year, 2 months ago (2017-03-20 05:18:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755053002/120001
1 year, 2 months ago (2017-03-23 21:49:40 UTC) #35
commit-bot: I haz the power
1 year, 2 months ago (2017-03-24 00:08:19 UTC) #38
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/6b815d45f10ca1b8fb208647f2a0...

Powered by Google App Engine
This is Rietveld 408576698