Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 2755053002: Generate the storage of pseudoBits and styleType in ComputedStyleBase. (Closed)

1 year ago by shend
11 months, 4 weeks ago
blink-reviews,, chromium-reviews
Target Ref:


Generate the storage of pseudoBits and styleType in ComputedStyleBase. In ComputedStyle, pseudoBits and styleType are two data members used for storing psuedoelement styles. Their interface is difficult to generate because: 1) They share the same enum, but not all enum values are valid for styleType. 2) pseudoBits is a bit set, which we can't generate yet. This patch uses the 'storage_only' template to move the storage of both fields to ComputedStyleBase first, and keep the interfaces handwritten. This is prework for either generating those fields properly or removing pseudo style information from ComputedStyle entirely. Diff of generated files: BUG=628043 Review-Url: Cr-Commit-Position: refs/heads/master@{#459290} Committed:

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fix default values #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #


Total messages: 38 (33 generated)
Hi Alan, PTAL :)
1 year ago (2017-03-17 00:43:56 UTC) #2
alancutter (OOO until 2018)
Please upload the generated diff.
12 months ago (2017-03-20 05:14:13 UTC) #3
alancutter (OOO until 2018)
lgtm. I think the "// Not generated" could be more explicit about what's not generated ...
12 months ago (2017-03-20 05:18:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at
12 months ago (2017-03-23 21:49:40 UTC) #35
commit-bot: I haz the power
11 months, 4 weeks ago (2017-03-24 00:08:19 UTC) #38
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as

Powered by Google App Engine
This is Rietveld 408576698