Removed webControllerDidSuppressDialog: callback.

Removed webControllerDidSuppressDialog: callback.

Replaced with WebStateObserver::DidSuppressDialog callback.

In content dialogs suppression is implemented via a single callback:
WebContentsDelegate::ShouldSuppressDialogs. This callback is called
before showing a dialog.

On iOS implementing the same API would require a roundtrip
(JS->Native->JS). This is because WKWebView does not provide any
callbacks for showing geolocation dialogs. So on iOS dialogs blocking is
implemented in JS as a boolean flag which is set by
WebState::SetShouldSuppressDialogs. Embedder still needs a callback to
know if the dialog was suppressed which is implemented as
WebStateObserver::DidSuppressDialog and require only one JS->Native
message.

BUG=674991
Review-Url: https://codereview.chromium.org/2755013002
Cr-Commit-Position: refs/heads/master@{#457764}
Committed: https://chromium.googlesource.com/chromium/src/+/e1886452ae27293d06b04655ccae3a25811d62e6

[Eugene But (OOO till 7-30), 2017-03-16 22:53:19]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 22:54:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 23:40:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 23:40:46]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-03-17 00:19:06]

eugenebut@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2017-03-17 12:00:45]

lgtm

[Eugene But (OOO till 7-30), 2017-03-17 14:34:29]

Thanks!

[Eugene But (OOO till 7-30), 2017-03-17 14:34:35]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-17 14:34:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 14:40:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489761275070610,
"parent_rev": "fb45b47dfa3c3c7f40c5b5b6c4d06a9de480f49d", "commit_rev":
"5eca5543aa892e5ba6f512a5c6cb656d4bb7e3fa"}

[commit-bot: I haz the power, 2017-03-17 14:45:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489761275070610,
"parent_rev": "d9b4a4ab9e75abdbbd5773f6ba17a26ba7571695", "commit_rev":
"e1886452ae27293d06b04655ccae3a25811d62e6"}

[commit-bot: I haz the power, 2017-03-17 14:46:37]

Description was changed from

==========
Removed webControllerDidSuppressDialog: callback.

Replaced with WebStateObserver::DidSuppressDialog callback.

In content dialogs suppression is implemented via a single callback:
WebContentsDelegate::ShouldSuppressDialogs. This callback is called
before showing a dialog.

On iOS implementing the same API would require a roundtrip
(JS->Native->JS). This is because WKWebView does not provide any
callbacks for showing geolocation dialogs. So on iOS dialogs blocking is
implemented in JS as a boolean flag which is set by
WebState::SetShouldSuppressDialogs. Embedder still needs a callback to
know if the dialog was suppressed which is implemented as
WebStateObserver::DidSuppressDialog and require only one JS->Native
message.

BUG=674991
==========

to

==========
Removed webControllerDidSuppressDialog: callback.

Replaced with WebStateObserver::DidSuppressDialog callback.

In content dialogs suppression is implemented via a single callback:
WebContentsDelegate::ShouldSuppressDialogs. This callback is called
before showing a dialog.

On iOS implementing the same API would require a roundtrip
(JS->Native->JS). This is because WKWebView does not provide any
callbacks for showing geolocation dialogs. So on iOS dialogs blocking is
implemented in JS as a boolean flag which is set by
WebState::SetShouldSuppressDialogs. Embedder still needs a callback to
know if the dialog was suppressed which is implemented as
WebStateObserver::DidSuppressDialog and require only one JS->Native
message.

BUG=674991

Review-Url: https://codereview.chromium.org/2755013002
Cr-Commit-Position: refs/heads/master@{#457764}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1886452ae27293d06b04655ccae...
==========

[commit-bot: I haz the power, 2017-03-17 14:46:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1886452ae27293d06b04655ccae...