ios/web/public/web_state/web_state.h - Issue 2755013002: Removed webControllerDidSuppressDialog: callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/web_state/web_state.h

Issue 2755013002: Removed webControllerDidSuppressDialog: callback. (Closed)

Patch Set: Self review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/public/web_state/web_state.h

diff --git a/ios/web/public/web_state/web_state.h b/ios/web/public/web_state/web_state.h

index c54cbad34544e7e05d76704662209acf42d30efc..5010d435b604af0f80bef362f2d8c4d64ebc18d1 100644

--- a/ios/web/public/web_state/web_state.h

+++ b/ios/web/public/web_state/web_state.h

@@ -100,8 +100,9 @@ class WebState : public base::SupportsUserData {

virtual bool IsWebUsageEnabled() const = 0;

virtual void SetWebUsageEnabled(bool enabled) = 0;

- // Whether or not dialogs (JavaScript dialogs, HTTP auths and window.open)

- // calls should be suppressed. Default is false.

+ // Whether or not dialogs (JavaScript, geolocation) and window open requests

+ // should be suppressed. Default is false. When dialog is suppressed

+ // |WebStateObserver::DidSuppressDialog| will be called.

virtual bool ShouldSuppressDialogs() const = 0;

virtual void SetShouldSuppressDialogs(bool should_suppress) = 0;