Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2754993002: Fix caret invalidation when a block is removed (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix caret invalidation when a block is removed Clear previous and/or current block when a block is being removed. BUG=701267 Review-Url: https://codereview.chromium.org/2754993002 Cr-Commit-Position: refs/heads/master@{#457597} Committed: https://chromium.googlesource.com/chromium/src/+/eeaca73ad3f97a71c35c8298ccf691ebad35161d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -12 lines) Patch
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h View 2 chunks +6 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp View 3 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Xianzhu
Sorry for the bugs of caret paint invalidation. This bug is really a result of ...
3 years, 9 months ago (2017-03-16 21:11:13 UTC) #4
chrishtr
lgtm
3 years, 9 months ago (2017-03-16 21:28:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754993002/1
3 years, 9 months ago (2017-03-16 21:48:14 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:08:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eeaca73ad3f97a71c35c8298ccf6...

Powered by Google App Engine
This is Rietveld 408576698