Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp

Issue 2754993002: Fix caret invalidation when a block is removed (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
diff --git a/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp b/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
index cb1f6b27d450fd1257f15c8c0a946b89b4d54448..efe03c01a59b93b3c173038b1464730cab3ae16f 100644
--- a/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
+++ b/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp
@@ -115,6 +115,23 @@ LayoutRect CaretDisplayItemClient::computeCaretRect(
caretLocalRectWithWritingMode);
}
+void CaretDisplayItemClient::clearPreviousVisualRect(const LayoutBlock& block) {
+ if (block == m_layoutBlock) {
+ m_visualRect = LayoutRect();
+ m_localRect = LayoutRect();
+ }
+ if (block == m_previousLayoutBlock)
+ m_visualRectInPreviousLayoutBlock = LayoutRect();
+}
+
+void CaretDisplayItemClient::layoutBlockWillBeDestroyed(
+ const LayoutBlock& block) {
+ if (block == m_layoutBlock)
+ m_layoutBlock = nullptr;
+ if (block == m_previousLayoutBlock)
+ m_previousLayoutBlock = nullptr;
+}
+
void CaretDisplayItemClient::updateStyleAndLayoutIfNeeded(
const PositionWithAffinity& caretPosition) {
// This method may be called multiple times (e.g. in partial lifecycle

Powered by Google App Engine
This is Rietveld 408576698