MD Settings: always let users get to autofill/passwords page

MD Settings: always let users get to autofill/passwords page

R=hcarmona@chromium.org
BUG=702242
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2754873003
Cr-Commit-Position: refs/heads/master@{#457561}
Committed: https://chromium.googlesource.com/chromium/src/+/7bc04f5e1bfff73c5ed2077690fa89649ea12566

[Dan Beam, 2017-03-16 19:18:20]

Description was changed from

==========
MD Settings: always let users get to autofill/passwords page

R=hcarmona@chromium.org
BUG=702242
==========

to

==========
MD Settings: always let users get to autofill/passwords page

R=hcarmona@chromium.org
BUG=702242
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-16 19:18:50]

this was privacy reviewer feedback

[Dan Beam, 2017-03-16 19:18:56]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 19:19:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2017-03-16 19:26:42]

LGTM if checkbox click doesn't bubble to parent.

https://codereview.chromium.org/2754873003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/2754873003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:30:
settings.navigateTo(settings.Route.MANAGE_PASSWORDS);
We probably still want to ignore clicks on the toggle. IIRCC this was bubbling
to the parent.

On second thought, I don't know if this was toggle specific behavior, haven't
tried w/ a checkbox.

[hcarmona, 2017-03-16 19:30:02]

On 2017/03/16 19:26:42, hcarmona wrote:
> LGTM if checkbox click doesn't bubble to parent.
> 
>
https://codereview.chromium.org/2754873003/diff/1/chrome/browser/resources/se...
> File
>
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
> (right):
> 
>
https://codereview.chromium.org/2754873003/diff/1/chrome/browser/resources/se...
>
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:30:
> settings.navigateTo(settings.Route.MANAGE_PASSWORDS);
> We probably still want to ignore clicks on the toggle. IIRCC this was bubbling
> to the parent.
> 
> On second thought, I don't know if this was toggle specific behavior, haven't
> tried w/ a checkbox.

NVM, this is LGTM, my memory betrays me about toggle/checkbox.

[Dan Beam, 2017-03-16 19:37:57]

On 2017/03/16 19:30:02, hcarmona wrote:
> On 2017/03/16 19:26:42, hcarmona wrote:
> > LGTM if checkbox click doesn't bubble to parent.
> > 
> >
>
https://codereview.chromium.org/2754873003/diff/1/chrome/browser/resources/se...
> > File
> >
>
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
> > (right):
> > 
> >
>
https://codereview.chromium.org/2754873003/diff/1/chrome/browser/resources/se...
> >
>
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:30:
> > settings.navigateTo(settings.Route.MANAGE_PASSWORDS);
> > We probably still want to ignore clicks on the toggle. IIRCC this was
bubbling
> > to the parent.
> > 
> > On second thought, I don't know if this was toggle specific behavior,
haven't
> > tried w/ a checkbox.
> 
> NVM, this is LGTM, my memory betrays me about toggle/checkbox.

i had the exact same thought, but i tried it locally and it was fine... I am not
sure (however) exactly what code is preventing this.  fine to go forward with
this for now.

[Dan Beam, 2017-03-16 19:38:01]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-03-16 19:38:07]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-03-16 19:38:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 20:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:47:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-03-16 20:48:33]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:49:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 21:31:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489697313955700, "parent_rev":
"6a5f508e65cf947c6292fe8578868d0fe739f0aa", "commit_rev":
"7bc04f5e1bfff73c5ed2077690fa89649ea12566"}

[commit-bot: I haz the power, 2017-03-16 21:46:35]

Description was changed from

==========
MD Settings: always let users get to autofill/passwords page

R=hcarmona@chromium.org
BUG=702242
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: always let users get to autofill/passwords page

R=hcarmona@chromium.org
BUG=702242
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2754873003
Cr-Commit-Position: refs/heads/master@{#457561}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bc04f5e1bfff73c5ed2077690fa...
==========

[commit-bot: I haz the power, 2017-03-16 21:46:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7bc04f5e1bfff73c5ed2077690fa...