Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3228)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Issue 2754873003: MD Settings: always let users get to autofill/passwords page (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
index b5d69c41aa43eb6fcf01f1597bfced7578035139..0598f0298e8f8515b7fc4ba993b5e115a4c9521c 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
@@ -2,14 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-/**
- * @fileoverview 'settings-passwords-and-forms-page' is the settings page
- * for passwords and auto fill.
- */
-
-(function() {
-'use strict';
-
Polymer({
is: 'settings-passwords-and-forms-page',
@@ -26,11 +18,7 @@ Polymer({
* @private
*/
onAutofillTap_: function(event) {
- // Ignore clicking on the toggle button and verify autofill is enabled.
- if (Polymer.dom(event).localTarget != this.$.autofillToggle &&
- this.getPref('autofill.enabled').value) {
- settings.navigateTo(settings.Route.AUTOFILL);
- }
+ settings.navigateTo(settings.Route.AUTOFILL);
},
/**
@@ -39,25 +27,6 @@ Polymer({
* @private
*/
onPasswordsTap_: function(event) {
- // Ignore clicking on the toggle button and only expand if the manager is
- // enabled.
- if (Polymer.dom(event).localTarget != this.$.passwordToggle &&
- this.getPref('credentials_enable_service').value) {
- settings.navigateTo(settings.Route.MANAGE_PASSWORDS);
- }
- },
-
- /**
- * Return "secondary-action" to be used as the dom-class name if the toggle
- * is on.
- * @private
- * @param {boolean} isToggleOn whether or not the associated toggle is on.
- */
- secondaryActionClass_: function(isToggleOn) {
- // TODO(scottchen): Having to do this is kind of annoying, but it'll be a
- // temporary patch. As we have plans to move the toggle completely into the
- // subpages themselves, this code *should* be eliminated soon.
- return isToggleOn ? 'secondary-action' : '';
+ settings.navigateTo(settings.Route.MANAGE_PASSWORDS);
hcarmona 2017/03/16 19:26:42 We probably still want to ignore clicks on the tog
},
});
-})();

Powered by Google App Engine
This is Rietveld 408576698