Issue 2754843002: Update the File Picker UMA metric to account for extensions, as per spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2754843002: Update the File Picker UMA metric to account for extensions, as per spec. (Closed)

Created:
3 years, 9 months ago by Finnur

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Update the File Picker UMA metric to account for extensions, as per spec. Note: The list of extensions is not permanent, and will be removed once we have the data we need. BUG=699536 Review-Url: https://codereview.chromium.org/2746143002 Cr-Commit-Position: refs/heads/master@{#456698} (cherry picked from commit e0dbc85ff55c7ec0e32dcf731ca7ff31543866da) Review-Url: https://codereview.chromium.org/2754843002 . Cr-Commit-Position: refs/branch-heads/3029@{#237} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/bb2ad2264a7922af6c049489c8c26bd7b7fa7685

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -0 lines)			Patch
	M	ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java	View		2 chunks	+35 lines, -0 lines	0 comments	Download
	M	ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Finnur

3 years, 9 months ago (2017-03-16 12:59:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bb2ad2264a7922af6c049489c8c26bd7b7fa7685.