Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2746143002: Update the File Picker UMA metric to account for extensions, as per spec. (Closed)

Created:
3 years, 9 months ago by Finnur
Modified:
3 years, 9 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the File Picker UMA metric to account for extensions, as per spec. Note: The list of extensions is not permanent, and will be removed once we have the data we need. BUG=699536 Review-Url: https://codereview.chromium.org/2746143002 Cr-Commit-Position: refs/heads/master@{#456698} Committed: https://chromium.googlesource.com/chromium/src/+/e0dbc85ff55c7ec0e32dcf731ca7ff31543866da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 2 chunks +35 lines, -0 lines 0 comments Download
M ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
Finnur
3 years, 9 months ago (2017-03-13 14:48:59 UTC) #3
Peter Beverloo
lgtm
3 years, 9 months ago (2017-03-13 15:17:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746143002/1
3 years, 9 months ago (2017-03-14 10:32:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/384797)
3 years, 9 months ago (2017-03-14 10:39:19 UTC) #13
Finnur
Miguel, can you give OWNERS approval?
3 years, 9 months ago (2017-03-14 12:41:38 UTC) #15
Finnur
And feel free to tick the CQ box if this looks OK to you.
3 years, 9 months ago (2017-03-14 12:42:00 UTC) #16
Peter Beverloo
On 2017/03/14 12:42:00, Finnur wrote: > And feel free to tick the CQ box if ...
3 years, 9 months ago (2017-03-14 12:56:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746143002/1
3 years, 9 months ago (2017-03-14 14:34:59 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 14:40:27 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0dbc85ff55c7ec0e32dcf731ca7...

Powered by Google App Engine
This is Rietveld 408576698