Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2754793004: Update messages.yaml with asynchronous messages. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -57 lines) Patch
M pkg/compiler/lib/src/parser/element_listener.dart View 2 chunks +4 lines, -57 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +41 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
ahe
3 years, 9 months ago (2017-03-17 17:31:37 UTC) #2
ahe
3 years, 9 months ago (2017-03-22 08:29:25 UTC) #4
ahe
Karl, could you take a look? Johnni is OOO.
3 years, 9 months ago (2017-03-22 08:29:57 UTC) #6
karlklose
LGTM
3 years, 9 months ago (2017-03-22 08:44:06 UTC) #7
ahe
3 years, 9 months ago (2017-03-22 11:27:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
002d5c7150bbf6564514b5acd9c252669fea1a83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698