Generate methods for reporting problems.

Generate methods for reporting problems.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/2562ed28cba4bdb90a11a85b8f16ef3894808a0b

[ahe, 2017-03-17 18:43:30]

Patchset #2 (id:20001) has been deleted

[ahe, 2017-03-17 18:44:36]

ahe@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-03-17 21:57:52]

lgtm

https://codereview.chromium.org/2754383002/diff/1/pkg/front_end/tool/_fasta/g...
File pkg/front_end/tool/_fasta/generate_messages.dart (right):

https://codereview.chromium.org/2754383002/diff/1/pkg/front_end/tool/_fasta/g...
pkg/front_end/tool/_fasta/generate_messages.dart:20: new
Set<String>.from(yaml.keys.map((String s) => "ErrorKind.$s"));
Oh, I see that you are trying to match error kinds and keys in the yaml file. Do
we ever expect to have more errors that are not covered by this enum? For
example, errors from the type-system or errors that we want to still collect in
our yaml file, but that are produced by other tools, like analyzer?

If so, it might be worth having a name that can be different than the
error-kind, for example:

some_error:
  frontend_kind: SomeError
  message: ...
  ...

https://codereview.chromium.org/2754383002/diff/1/pkg/front_end/tool/_fasta/g...
pkg/front_end/tool/_fasta/generate_messages.dart:102: if (text == null) return
"";
maybe generate a comment instead? e.g.:
  /* no $name provided. */

to avoid the empty line in the generated output?

[ahe, 2017-03-22 11:06:57]

Thank you, Siggi!

https://codereview.chromium.org/2754383002/diff/1/pkg/front_end/tool/_fasta/g...
File pkg/front_end/tool/_fasta/generate_messages.dart (right):

https://codereview.chromium.org/2754383002/diff/1/pkg/front_end/tool/_fasta/g...
pkg/front_end/tool/_fasta/generate_messages.dart:20: new
Set<String>.from(yaml.keys.map((String s) => "ErrorKind.$s"));
On 2017/03/17 21:57:52, Siggi Cherem (dart-lang) wrote:
> Oh, I see that you are trying to match error kinds and keys in the yaml file.
Do
> we ever expect to have more errors that are not covered by this enum? For
> example, errors from the type-system or errors that we want to still collect
in
> our yaml file, but that are produced by other tools, like analyzer?
> 
> If so, it might be worth having a name that can be different than the
> error-kind, for example:
> 
> some_error:
>   frontend_kind: SomeError
>   message: ...
>   ...

Actually, I was hoping to replace ErrorKind with invocations of methods in this
CL.

https://codereview.chromium.org/2754383002/diff/1/pkg/front_end/tool/_fasta/g...
pkg/front_end/tool/_fasta/generate_messages.dart:102: if (text == null) return
"";
On 2017/03/17 21:57:52, Siggi Cherem (dart-lang) wrote:
> maybe generate a comment instead? e.g.:
>   /* no $name provided. */
> 
> to avoid the empty line in the generated output?

I'll use a StringBuffer in a follow-up CL.

[ahe, 2017-03-22 11:30:59]

Description was changed from

==========
Generate methods for reporting problems.
==========

to

==========
Generate methods for reporting problems.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2562ed28cba4bdb90a11a85b8f16ef3894808a0b
==========

[ahe, 2017-03-22 11:31:00]

Committed patchset #1 (id:1) manually as
2562ed28cba4bdb90a11a85b8f16ef3894808a0b.